Add support for deployment on Goerli testnet #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Görli became a recommended test network after Ropsten's deprecation notice (https://blog.ethereum.org/2022/06/21/testnet-deprecation/). We're modifying our GitHub Actions workflows for deploying contracts and dashboards to support the deployment on Görli. In this commit we're modifying workflow for building/publishing T dabshoard for testing purposes.
All the `@keep-network` and `@threshold-network` pakages used as dependencies of the Token Dashboard have now the `develop`-tagged NPM packages (with the latest code meant for development). We will no longer use the version ranges and will use the `develop` tag instead to define the dependencies.
Görli became a recommended test network after Ropsten's deprecation notice (https://blog.ethereum.org/2022/06/21/testnet-deprecation/). We're modifying the README section about deployment of T dashboard to describe deployment on Görli testnet instead of Ropsten testnet.
michalinacienciala
force-pushed
the
ci-goerli
branch
6 times, most recently
from
6eaf0f4
to
75733e9
Compare
We provide explicit version of the `keep-core` package, because using `goerli` tag results in `expected manifest` error - probably caused by bug in Yarn: yarnpkg/yarn#4731. We don't plan to publish new `@keep-network/keep-core` anytime soon, so this should be acceptable workaround.
As part of the task of switching T dApp from Ropsten to Goerli testnet (caused by announced soon deprecation of Ropsten) we need to update a bunch of maps listing supported networks and need to point to some contracts deployed on Goerli network. Note: As NuCypher hasn't deployed the `SimplePreApplication` contract on Goerli testnet, we're using stub contract.
michalinacienciala
force-pushed
the
ci-goerli
branch
from
928da9d
to
345900a
Compare
|
Preview uploaded to https://preview.dashboard.test.threshold.network/ci-goerli/index.html. |
r-czajkowski
requested changes
Jul 27, 2022
We can always use git revert if we want to restore the ropsten config.
|
Preview uploaded to https://preview.dashboard.test.threshold.network/ci-goerli/index.html. |
r-czajkowski
approved these changes
Jul 28, 2022
georgeweiler
pushed a commit
that referenced
this pull request
Sep 8, 2022
Add support for deployment on Goerli testnet Görli became a recommended test network after Ropsten's deprecation notice (https://blog.ethereum.org/2022/06/21/testnet-deprecation/). We're modifying our GitHub Actions workflows for deploying contracts and dashboards to support the deployment on Görli. In this PR we're modifying workflow for building/publishing T dashboard for testing purposes. We also modify T dApp code which in couple places was Ropsten-specific. Among some other changes, we have specified: * merkle drop contract address for Goerli: `0x55F836777302CE096CC7770142a8262A2627E2e9` * stub `SimplePreApplication` for Goerli: `0x829fdCDf6Be747FEA37518fBd83dF70EE371fCf2` * multicall contract address for Goerli: `0x77dca2c955b15e9de4dbbcf1246b4b85b651e50e`
99 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Görli became a recommended test network after Ropsten's deprecation
notice (https://blog.ethereum.org/2022/06/21/testnet-deprecation/).
We're modifying our GitHub Actions workflows for deploying contracts
and dashboards to support the deployment on Görli. In this PR we're
modifying workflow for building/publishing T dashboard for testing
purposes. We also modify T dApp code which in couple places was
Ropsten-specific. Among some other changes, we have specified:
0x55F836777302CE096CC7770142a8262A2627E2e9SimplePreApplicationfor Goerli:0x829fdCDf6Be747FEA37518fBd83dF70EE371fCf20x77dca2c955b15e9de4dbbcf1246b4b85b651e50eTODO:
0x55F836777302CE096CC7770142a8262A2627E2e9SimplePreApplicationon Goerli (@r-czajkowski): ``token-dashboardrepo to Goerli