-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor query implementation for the Graph's service migration #123
Refactor query implementation for the Graph's service migration #123
Conversation
src/config/subgraph.ts
Outdated
|
||
export const TBTC_SUBGRAPH_ID = "DETCX5Xm6tJfctRcZAxhQB9q3aK8P4BXLbujHmzEBXYV" | ||
|
||
export const SUBGRAPH_GATEWAY_URL = `https://gateway-arbitrum.network.thegraph.com/api/${process.env.SUBGRAPH_API_KEY}/subgraphs/id/` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering why the subgraph gateway is gateway-arbitrum
when tbtc is on mainnet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Graph processes Layer 1 (L1) data on Arbitrum to reduce costs, enhance scalability, and improve efficiency. This enables faster querying and processing of subgraphs, making the entire curation process more cost-effective.
For more information, please refer to: https://thegraph.com/docs/en/arbitrum/l2-transfer-tools-guide/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks ok. Have to test it with subgraph api key though, which I don't have yet. I will probably continue this review tomorrow (unless I will have the key earlier 😛 )
Only tbtc graph was not working so we don't need to replace the graph for t network. Replacing it the staking tvl section to show a wrong value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
Description
Refactor the querying implementation in response to The Graph's recent transition from the hosted-service to the Studio service.
Key changes include:
Updated query format to be compatible with The Graph Studio services.
Introduced requirements for a subgraph ID and a subgraph API key secret to authenticate queries.
These changes are necessary to maintain our application's connectivity with The Graph's services and ensure seamless data querying.
Notice
Pull Request Type
Fixes #121
Testing
Please outline all testing steps