Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecosystem section #94

Merged
merged 38 commits into from
Sep 14, 2023
Merged

Ecosystem section #94

merged 38 commits into from
Sep 14, 2023

Conversation

evandrosaturnino
Copy link
Contributor

Description

Add the ecosystem page to the website with multiple sections - Updated navbar and footer to link the new page.

Notice

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Closes issue #90

Testing

Please outline all testing steps

  1. Clone the repo - git clone https://github.com/threshold-network/website.git
  2. Install dependencies - yarn install
  3. Run the app - yarn start

Screenshots (if applicable)

image

image

image

For mobile:
image

@github-actions
Copy link

3 similar comments
@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did first round of review. Overall looking great! It works awesome on all resolutions.

Left some comments to look at before the merge

src/templates/home-page/SectionTemplate.tsx Outdated Show resolved Hide resolved
src/templates/home-page/SectionTemplate.tsx Outdated Show resolved Hide resolved
src/templates/home-page/SectionTemplate.tsx Outdated Show resolved Hide resolved
src/templates/home-page/SectionTemplate.tsx Outdated Show resolved Hide resolved
src/components/IntegrationCard.tsx Outdated Show resolved Hide resolved
description: tBTC is a decentralized, BTC-backed token with 1-1 price peg to Bitcoin. It allows holders to use Bitcoin on DeFi.
categories:
- label: project
timestamp: 1675199559
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know what timestamp should each project/tool have? I couldn't find any info about it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of them have hard date we can get from the source, e.g.: Subgraph and Dune analytics dashboard.
Others I took from the official launch announcement (tBTC v2, Taco, and thUSD testnet launch), and those few that don't have either, I took from the first time it was mentioned on Discord to the community.

src/content/pages/ecosystem/index.md Outdated Show resolved Hide resolved
src/content/pages/ecosystem/index.md Outdated Show resolved Hide resolved
static/admin/config.yml Outdated Show resolved Hide resolved
src/templates/ecosystem-page/ProjectsAndTools.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some more comments to look at

src/content/pages/ecosystem/index.md Outdated Show resolved Hide resolved
static/admin/config.yml Outdated Show resolved Hide resolved
src/templates/ecosystem-page/ProjectsAndTools.tsx Outdated Show resolved Hide resolved
src/utils/date.ts Outdated Show resolved Hide resolved
src/utils/date.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some final comments to look at before the merge

src/templates/ecosystem-page/CommunitySection.tsx Outdated Show resolved Hide resolved
}) => {
return (
<SimpleGrid columns={{ base: 1, md: 2 }} spacing={4} mt={6} mb={12}>
{cards.slice(0, 2).map((program: any, i) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can understand slicing it in the Prgrams and Events section since we want to diplay the newest ones there, but capping the number of social to two seems like a not good idea future-wise. We usually don't replace one of our socials with another but add another one to the ones that already exist.

I think this is a design question how do we want to resolve this. For three socials it will look like this:

image

I think it would be the best to leave the possibility to add more socials in the future and have the UI to properly reflect that but I'll leave that one to you to decide.

src/templates/ecosystem-page/ProjectsAndTools.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@github-actions
Copy link

@michalsmiarowski michalsmiarowski merged commit a0ead3b into main Sep 14, 2023
3 checks passed
@michalsmiarowski michalsmiarowski deleted the ecosystem-page branch September 14, 2023 15:22
@SorinQ
Copy link

SorinQ commented Sep 14, 2023

Hi there,
I've seen the changes you've made, @evandrosaturnino , and things are looking great.
Just one note: Could we switch the buttons as per the example below, just to maintain consistency between the cards with one button and those with two?

Screenshot 2023-09-14 at 18 47 12

Congrats!

@SorinQ
Copy link

SorinQ commented Sep 14, 2023

On mobile, can we better align these elements?

IMG_F251AE0180E1-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants