-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecosystem section #94
Conversation
Preview uploaded to https://preview.threshold.network/ecosystem-page/index.html. |
3 similar comments
Preview uploaded to https://preview.threshold.network/ecosystem-page/index.html. |
Preview uploaded to https://preview.threshold.network/ecosystem-page/index.html. |
Preview uploaded to https://preview.threshold.network/ecosystem-page/index.html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did first round of review. Overall looking great! It works awesome on all resolutions.
Left some comments to look at before the merge
src/content/pages/ecosystem/index.md
Outdated
description: tBTC is a decentralized, BTC-backed token with 1-1 price peg to Bitcoin. It allows holders to use Bitcoin on DeFi. | ||
categories: | ||
- label: project | ||
timestamp: 1675199559 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we know what timestamp should each project/tool have? I couldn't find any info about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of them have hard date we can get from the source, e.g.: Subgraph and Dune analytics dashboard.
Others I took from the official launch announcement (tBTC v2, Taco, and thUSD testnet launch), and those few that don't have either, I took from the first time it was mentioned on Discord to the community.
Preview uploaded to https://preview.threshold.network/ecosystem-page/index.html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some more comments to look at
Preview uploaded to https://preview.threshold.network/ecosystem-page/index.html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some final comments to look at before the merge
}) => { | ||
return ( | ||
<SimpleGrid columns={{ base: 1, md: 2 }} spacing={4} mt={6} mb={12}> | ||
{cards.slice(0, 2).map((program: any, i) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can understand slicing it in the Prgrams and Events
section since we want to diplay the newest ones there, but capping the number of social to two seems like a not good idea future-wise. We usually don't replace one of our socials with another but add another one to the ones that already exist.
I think this is a design question how do we want to resolve this. For three socials it will look like this:
I think it would be the best to leave the possibility to add more socials in the future and have the UI to properly reflect that but I'll leave that one to you to decide.
Preview uploaded to https://preview.threshold.network/ecosystem-page/index.html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
b9ce78c
to
30f9de3
Compare
Preview uploaded to https://preview.threshold.network/ecosystem-page/index.html. |
Hi there, Congrats! |
Description
Add the ecosystem page to the website with multiple sections - Updated navbar and footer to link the new page.
Notice
Pull Request Type
Issue (if applicable)
Closes issue #90
Testing
Please outline all testing steps
Screenshots (if applicable)
For mobile: