From 77bac6a6ec86e4108519249c39ed96cf264883a0 Mon Sep 17 00:00:00 2001 From: Jianyuan Jiang Date: Fri, 10 Nov 2023 15:15:45 +0800 Subject: [PATCH] config(ticdc): change case-sensitive default value (#10049) close pingcap/tiflow#10047 --- cdc/api/v2/model_test.go | 2 +- cdc/model/changefeed_test.go | 2 +- pkg/config/replica_config.go | 2 +- tests/integration_tests/api_v2/cases.go | 2 +- tests/integration_tests/cli/run.sh | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cdc/api/v2/model_test.go b/cdc/api/v2/model_test.go index 8a33d3a388e..e6b68804d7b 100644 --- a/cdc/api/v2/model_test.go +++ b/cdc/api/v2/model_test.go @@ -31,7 +31,7 @@ import ( // note: this is api published default value, not change it var defaultAPIConfig = &ReplicaConfig{ MemoryQuota: config.DefaultChangefeedMemoryQuota, - CaseSensitive: true, + CaseSensitive: false, CheckGCSafePoint: true, BDRMode: util.AddressOf(false), EnableSyncPoint: util.AddressOf(false), diff --git a/cdc/model/changefeed_test.go b/cdc/model/changefeed_test.go index 318c0242f16..16dcbd5b914 100644 --- a/cdc/model/changefeed_test.go +++ b/cdc/model/changefeed_test.go @@ -247,7 +247,7 @@ func TestVerifyAndComplete(t *testing.T) { StartTs: 417257993615179777, Config: &config.ReplicaConfig{ MemoryQuota: 1073741824, - CaseSensitive: true, + CaseSensitive: false, CheckGCSafePoint: true, SyncPointInterval: util.AddressOf(time.Minute * 10), SyncPointRetention: util.AddressOf(time.Hour * 24), diff --git a/pkg/config/replica_config.go b/pkg/config/replica_config.go index 94ca5dfaadb..4d8b6ce0225 100644 --- a/pkg/config/replica_config.go +++ b/pkg/config/replica_config.go @@ -49,7 +49,7 @@ const ( var defaultReplicaConfig = &ReplicaConfig{ MemoryQuota: DefaultChangefeedMemoryQuota, - CaseSensitive: true, + CaseSensitive: false, CheckGCSafePoint: true, EnableSyncPoint: util.AddressOf(false), SyncPointInterval: util.AddressOf(10 * time.Minute), diff --git a/tests/integration_tests/api_v2/cases.go b/tests/integration_tests/api_v2/cases.go index f62cf45e011..9e336a016af 100644 --- a/tests/integration_tests/api_v2/cases.go +++ b/tests/integration_tests/api_v2/cases.go @@ -79,7 +79,7 @@ var customReplicaConfig = &ReplicaConfig{ // defaultReplicaConfig check if the default values is changed var defaultReplicaConfig = &ReplicaConfig{ MemoryQuota: 1024 * 1024 * 1024, - CaseSensitive: true, + CaseSensitive: false, CheckGCSafePoint: true, Filter: &FilterConfig{ Rules: []string{"*.*"}, diff --git a/tests/integration_tests/cli/run.sh b/tests/integration_tests/cli/run.sh index 3d27a3fbd98..4e38f238e48 100644 --- a/tests/integration_tests/cli/run.sh +++ b/tests/integration_tests/cli/run.sh @@ -73,7 +73,7 @@ function run() { # Update changefeed failed because changefeed is running cat - >"$WORK_DIR/changefeed.toml" <&1) - if [[ ! $changefeed_info == *"\"case_sensitive\":false"* ]]; then + if [[ ! $changefeed_info == *"\"case_sensitive\":true"* ]]; then echo "[$(date)] <<<<< changefeed info is not updated as expected ${changefeed_info} >>>>>" exit 1 fi