Skip to content
This repository has been archived by the owner on Apr 6, 2024. It is now read-only.

Update pyproject.toml #120

Closed
wants to merge 3 commits into from
Closed

Update pyproject.toml #120

wants to merge 3 commits into from

Conversation

Patarimi
Copy link

@Patarimi Patarimi commented May 4, 2023

I run in the same problem as #118.
This PR seems to fix the problem.
Maybe the version number needs to be increased ?

@antoine-de
Copy link

I think a new version number will be needed too to be published on pypi no?

I also need this, for now I cannot publish a package depending on the new typer version on pypi since my packge also depend on typer-cli (even if typer-cli is only in the dev dependencies).

@glass-ships
Copy link

+1 for this fix!

Is there anything holding it back? I'd be happy to jump in and help if need be!

@Patarimi
Copy link
Author

@tiangolo What is your opinion on this pull request ?

@rpmcginty
Copy link

@tiangolo I can see you are hard at work to get fastapi ready for pydantic v2, so I know this could fall to the wayside. That said, I think this is a pretty clean and low stakes change. It would be really helpful to merge this to utilize the documentation generation tool.

FWIW, when using this fork as a dependency ("typer-cli @ git+ssh://git@github.com/Patarimi/typer-cli"), I can verify documentation tool can now be run to generate docs.

@yu-iskw
Copy link

yu-iskw commented Jun 28, 2023

@tiangolo I would like to relax the version constraints too. The pull request would be helpful for many typer users. We really appreciate if you could take a look at it. Thanks!

@rpmcginty
Copy link

@tiangolo would you be able to review this change?

@rpmcginty
Copy link

@tiangolo is it possible to review this?

@austin-silk
Copy link

@tiangolo Please approve this PR 🙏

@UltimateLobster
Copy link

@tiangolo Considering the small size of the changes and the fact that it blocks using the newest versions of typer. we'd appreciate it if you could review this PR 🙏

@vitorquintanilha
Copy link

+1

1 similar comment
@fritz-astronomer
Copy link

+1

@glass-ships
Copy link

6 months later, no word at all...
Any updates one way or another?

@Patarimi
Copy link
Author

Patarimi commented Nov 20, 2023

I found this repo. It is actively maintains and offers more functionalities than typer-cli.

@trymzet
Copy link

trymzet commented Nov 30, 2023

Bumping, @tiangolo this seems like a trivial merge. BTW maybe add some more maintainers to the project so it doesn't die?

@begemotik
Copy link

Very sad seeing it in a hanging state.
Another try, @tiangolo hope you could find some time to review it.

@gianfrancodemarco
Copy link

Bump!

@vjeeva
Copy link

vjeeva commented Feb 21, 2024

+1 please @tiangolo!

@sixdimensionalarray
Copy link

+1 @tiangolo thank you

neprune added a commit to neprune/typer-cli that referenced this pull request Mar 4, 2024
@aschroede
Copy link

Also going to add my support for this pull request!

@PieterBunnenberg
Copy link

@tiangolo Please merge this change to keep compatibility with typer 0.9.0. We really want to migrate to typer 0.9.0, but this blocks us...

@PieterBunnenberg
Copy link

I created a discussion for this issue as well: #134

@tiangolo
Copy link
Owner

tiangolo commented Apr 6, 2024

Thanks @Patarimi and everyone for the discussion here! ☕

Now typer-cli is integrated into typer itself. 🚀

You no longer need (nor should) install typer-cli, instead install typer, and that's it, you get the typer command and everything.

And all the code is always in sync and up to date with the rest of Typer, etc. 🎉


Meanwhile, and just for compatibility, the same Typer repo also publishes the PyPI package typer-cli with exactly the same version as Typer, but the new typer-cli PyPI package (versions 0.12.1+) doesn't have anything, it just requires typer.

And the new versions of typer include the typer command, and the tools to run scripts, generate docs, etc.

As this repo is no longer relevant, I will archive it soon, everything is now in https://github.com/tiangolo/typer.

Given that, I'll close this one, thanks all! 🍰

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.