Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkPkg: Restore TPL Before Return #6298

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

os-d
Copy link
Contributor

@os-d os-d commented Oct 8, 2024

Description

This patch fixes a few instances of error cases in NetworkPkg returning after a RaiseTpl call without restoring the TPL first.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Code review.

Integration Instructions

N/A.

@os-d
Copy link
Contributor Author

os-d commented Oct 14, 2024

@ajfish @leiflindholm @mdkinney @SaloniKasbekar @Zclarkwilliams friendly ping to review this small PR.

@os-d
Copy link
Contributor Author

os-d commented Oct 21, 2024

@ajfish @leiflindholm @mdkinney @SaloniKasbekar @Zclarkwilliams another friendly ping to review please

@os-d
Copy link
Contributor Author

os-d commented Oct 24, 2024

@ajfish @leiflindholm @mdkinney @SaloniKasbekar @Zclarkwilliams can someone review this small PR?

@os-d
Copy link
Contributor Author

os-d commented Nov 5, 2024

@ajfish @leiflindholm @mdkinney @SaloniKasbekar @Zclarkwilliams can you please review this small PR to get it in for the stable tag?

@os-d
Copy link
Contributor Author

os-d commented Nov 18, 2024

@ajfish @leiflindholm @mdkinney @SaloniKasbekar @Zclarkwilliams there is no NetworkPkg maintainer, can you please review this small PR? The process is that the stewards need to review in the absence of a maintainer, right?

@mdkinney
Copy link
Member

There are reviewers and I asked them to review. Stewards can fill role of Maintainer after review is complete

@os-d
Copy link
Contributor Author

os-d commented Nov 18, 2024

@mdkinney it's been 6 weeks and the reviewers are not reviewing :)

@mdkinney
Copy link
Member

If this is considered a critical bug fix for edk2-stable202411, then please prefix title with [edk2-stable202411] and add justification for why this must be included in this release.

@os-d
Copy link
Contributor Author

os-d commented Nov 18, 2024

If this is considered a critical bug fix for edk2-stable202411, then please prefix title with [edk2-stable202411] and add justification for why this must be included in this release.

I don't think this needs to be included in the stable tag. It just had been sitting for 6 weeks so I was trying to get traction on the simple bugfixes here. They are bugfixes, but only ones seen through code inspection, so no urgency to get into the stable tag.

@os-d
Copy link
Contributor Author

os-d commented Nov 18, 2024

@mdkinney I have scoped this PR to only the restore TPL fixes and @Zclarkwilliams has reviewed. Please re-review when you have a chance. As I mentioned, I don't think this needs to hit the stable tag, but certainly can if desired.

This patch fixes a few instances of error cases in NetworkPkg
returning after a RaiseTPL call without restoring the TPL
first.

Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>
@mdkinney mdkinney added the push Auto push patch series in PR if all checks pass label Nov 22, 2024
@mergify mergify bot merged commit 0d12945 into tianocore:master Nov 22, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants