CryptoPkg: Apply gettimeofday() solution to BaseCryptLibMbedTls #6409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyi77
approved these changes
Nov 6, 2024
|
EDK2 has entered into code freeze. Will push it after next stable tag be released (11/22). |
AmyChan-Intel
force-pushed
the
Branch_master
branch
from
80623e0
to
2d09564
Compare
|
What problem this PR is trying to resolve? |
|
The previous change in BaseCryptLib turns gettimeofday() from a Macro into a function call, however the relative changes were missed in BaseCryptLibMbedTls.
Apply the same change to BaseCryptLibMbedTls can resolve the “unresolved external symbol gettimeofday” error for the build target which consumes BaseCryptLibMbedTls.
From: Jiewen Yao ***@***.***>
Sent: Friday, November 8, 2024 12:55 PM
To: tianocore/edk2 ***@***.***>
Cc: Chan, Amy ***@***.***>; Author ***@***.***>
Subject: Re: [tianocore/edk2] CryptoPkg: Apply gettimeofday() solution to BaseCryptLibMbedTls (PR #6409)
What problem this PR is trying to resolve?
—
Reply to this email directly, view it on GitHub<#6409 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AE4JZP2T7DRSRZQTA6BYM6LZ7Q72VAVCNFSM6AAAAABRH7JGECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRTG43DINZXGE>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
|
@mergify rebase |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
AmyChan-Intel
force-pushed
the
Branch_master
branch
4 times, most recently
from
19313f2
to
947fed4
Compare
BaseCryptLib turn gettimeofday() from a Macro into a function call, apply the same change to BaseCryptLibMbedTls Signed-off-by: Amy Chan <amy.chan@intel.com>
AmyChan-Intel
force-pushed
the
Branch_master
branch
from
947fed4
to
a64a90a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseCryptLib turn gettimeofday() from a Macro into a function call, apply the same change to BaseCryptLibMbedTls
Description
BaseCryptLib turn gettimeofday() from a Macro into a function call, apply the same change to BaseCryptLibMbedTls
Breaking change?
Impacts security?
Includes tests?
How This Was Tested
Local build and boot from emulator passed
Integration Instructions
N/A