UefiCpuPkg/PiSmmCpuDxeSmm:Check resource HOB range before mapping #6431
Conversation
tianocore-assign-reviewers
bot
requested review from
jiaxinwu,
kraxel,
niruiyu and
rahul1-kumar
| Count++; | ||
| ResourceHobEnd = Hob.ResourceDescriptor->PhysicalStart + Hob.ResourceDescriptor->ResourceLength; | ||
|
|
||
| if (ResourceHobEnd <= MaxPhysicalAddress) { |
There was a problem hiding this comment.
Just need assert:
ASSERT ((Hob.ResourceDescriptor->PhysicalStart < MaxPhysicalAddress) && (ResourceHobEnd < MaxPhysicalAddress))
There was a problem hiding this comment.
what if the unexpected behavior happens in release build?
There was a problem hiding this comment.
for any issue check, we will use the debug version. Here, it's just help us quick find the problem. debug log will also not output in release version.
There was a problem hiding this comment.
Per offline talk with Jiaxin, will add CpuDeadLoop here.
It maybe a better choice here to expose the invalid resource HOB range(MMIO range from platform) here early
| (*MemoryRegion)[Index].Attribute = EFI_MEMORY_XP; | ||
| if (Hob.ResourceDescriptor->ResourceAttribute == EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTED) { | ||
| (*MemoryRegion)[Index].Attribute |= EFI_MEMORY_RO; | ||
| ResourceHobEnd = Hob.ResourceDescriptor->PhysicalStart + Hob.ResourceDescriptor->ResourceLength; |
There was a problem hiding this comment.
You mean remove line 175 directly use the variable in line 177? I'm fine with it
There was a problem hiding this comment.
i mean once we assert, those code are not needed.
This commit is to check if the resource HOB range does not exceed the max supported physical address. The function BuildMemoryMapFromResDescHobs is to build Memory Region from resource HOBs. Then the memory maps will be used during creating or modifying SMM page table. If the resource HOB range exceeds the max supported physical address, then subsequent calling of PageTableMap() will fail. Signed-off-by: Dun Tan <dun.tan@intel.com>
td36
force-pushed
the
dev/td36/check_resource_HOB
branch
from
bb4499d
to
230dcfd
Compare
Description
This commit is to check if the resource HOB range does not exceed the max supported physical address.
The function BuildMemoryMapFromResDescHobs is to build Memory Region from resource HOBs. Then the memory maps will be used during creating or modifying SMM page table. If the resource HOB range exceeds the max supported physical address, then subsequent calling of PageTableMap() will fail.
How This Was Tested
Tested in Intel internal server platform with x86 standalone MM enabled and succussfully booted into shell