embed:::tunable.step_umap does not include target_weight in tunable params

[diegoperoni]

The problem

I think you must include target_weight in tunable function of step_umap as follows:

Reproducible example

tunable.step_umap = function (x, ...) {
tibble::tibble(
  name = c("num_comp", "neighbors", "min_dist", "learn_rate", "epochs", "target_weight"), 
  call_info = list(
    list(pkg = "dials", fun = "num_comp", range = c(1, 10)), 
    list(pkg = "dials", fun = "neighbors", range = c(5, 200)), 
    list(pkg = "dials", fun = "min_dist", range = c(-4, -0.69897)), 
    list(pkg = "dials", fun = "learn_rate"), 
    list(pkg = "dials", fun = "epochs", range = c(100, 700)),
    list(pkg = "dials", fun = "target_weight", range = c(0, 1))), 
  source = "recipe", component = "step_umap", component_id = x$id)
}

[EmilHvitfeldt]

this is correct! nice find!