From 37f7e5e4325200610c9ef165a8cde1d047db017f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=98topepo=E2=80=99?= <‘mxkuhn@gmail.com’> Date: Wed, 14 Feb 2024 13:05:17 -0500 Subject: [PATCH 1/2] changes for #1039 --- NEWS.md | 2 ++ R/predict_hazard.R | 1 - R/predict_survival.R | 1 - 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS.md b/NEWS.md index 78f412ac8..0bf61b76c 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,7 @@ # parsnip (development version) +* We no longer add `eval_time` arguments to the prediction specification (#1039). + * parsnip now lets the engines for [mlp()] check for acceptable values of the activation function (#1019) * Tightened logic for outcome checking. This resolves issues—some errors and some silent failures—when atomic outcome variables have an attribute (#1060, #1061). diff --git a/R/predict_hazard.R b/R/predict_hazard.R index 84b49e13a..fe75b5007 100644 --- a/R/predict_hazard.R +++ b/R/predict_hazard.R @@ -33,7 +33,6 @@ predict_hazard.model_fit <- function(object, new_data <- object$spec$method$pred$hazard$pre(new_data, object) # Pass some extra arguments to be used in post-processor - object$spec$method$pred$hazard$args$eval_time <- eval_time pred_call <- make_pred_call(object$spec$method$pred$hazard) res <- eval_tidy(pred_call) diff --git a/R/predict_survival.R b/R/predict_survival.R index fbfe4eefe..cbe4a86fe 100644 --- a/R/predict_survival.R +++ b/R/predict_survival.R @@ -35,7 +35,6 @@ predict_survival.model_fit <- function(object, new_data <- object$spec$method$pred$survival$pre(new_data, object) # Pass some extra arguments to be used in post-processor - object$spec$method$pred$survival$args$eval_time <- eval_time pred_call <- make_pred_call(object$spec$method$pred$survival) res <- eval_tidy(pred_call) From 34b80b9f9649438c5e2192499bf9eb4282f62b19 Mon Sep 17 00:00:00 2001 From: Max Kuhn Date: Wed, 14 Feb 2024 14:45:24 -0500 Subject: [PATCH 2/2] Update NEWS.md Co-authored-by: Hannah Frick --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 0bf61b76c..5627e18ed 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,6 +1,6 @@ # parsnip (development version) -* We no longer add `eval_time` arguments to the prediction specification (#1039). +* We no longer add `eval_time` arguments to the prediction specification for the engine (#1039). * parsnip now lets the engines for [mlp()] check for acceptable values of the activation function (#1019)