Better webfakes skipping (#385)

And move to better home for helpers Closes #346
tidyverse · Jan 23, 2024 · 74ad186 · 74ad186
1 parent b3b6916
commit 74ad186
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/R/testthat.R → tests/testthat/helper.R b/R/testthat.R → tests/testthat/helper.R
@@ -1,3 +1,9 @@
+local_test_app <- function(envir = parent.frame()) {
+  skip_if_not_installed("webfakes")
+
+  webfakes::local_app_process(app_request(), .local_envir = envir)
+}
+
 app_request <- function() {
   req_json <- function(req, res) {
     out <- list(

diff --git a/tests/testthat/test-form.R b/tests/testthat/test-form.R
@@ -188,8 +188,7 @@ test_that("handles no buttons", {
 })
 
 test_that("can submit using three primary techniques", {
-  skip_if_not_installed("webfakes")
-  app <- webfakes::local_app_process(app_request())
+  app <- local_test_app()
 
   html <- minimal_html('
     <form action="/">

diff --git a/tests/testthat/test-session.R b/tests/testthat/test-session.R
@@ -86,7 +86,7 @@ test_that("can find link by position, content, css, or xpath", {
 })
 
 test_that("can submit a form", {
-  app <- webfakes::local_app_process(app_request())
+  app <- local_test_app()
 
   html <- minimal_html('
     <form action="/">