Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip tests requiring webfakes #346

Closed
wants to merge 2 commits into from

Conversation

MichaelChirico
Copy link
Contributor

No description provided.

@hadley
Copy link
Member

hadley commented Mar 1, 2022

Would you mind explaining the root problem?

@MichaelChirico
Copy link
Contributor Author

pretty simple: webfakes is unavailable 🙂

@hadley
Copy link
Member

hadley commented Mar 2, 2022

And what's the root cause of that? 😆

@MichaelChirico
Copy link
Contributor Author

two main things:

  1. there's manual overhead for us to bring in incremental packages -- https://opensource.google/documentation/reference/thirdparty. so unless we need Suggests functionality, we usually don't import those deps (e.g. just to pass a small # of tests)
  2. our test infra blocks web calls. i'm not sure webfakes even can work (speculative -- haven't looked into webfakes much)

we have already applied the patch to our fork, but filed here as well thinking it's more generally useful. but do feel free to close.

@hadley
Copy link
Member

hadley commented Mar 3, 2022

Thanks! Just wanted to understand the root context; I'll likely merge when I'm next working on testthat.

hadley added a commit that referenced this pull request Jan 23, 2024
And move to better home for helpers

Closes #346
@hadley hadley mentioned this pull request Jan 23, 2024
@hadley hadley closed this in #385 Jan 23, 2024
hadley added a commit that referenced this pull request Jan 23, 2024
And move to better home for helpers

Closes #346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants