Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pr template #4

Merged
merged 1 commit into from
Jul 7, 2022
Merged

fix pr template #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 24 additions & 37 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,55 +1,42 @@
## PR Type

<!-- Select one and remove others. If an appropriate one is not listed, please write by yourself. -->

- New Feature
- Improvement
- Bug Fix

## Related Links

<!-- Please write related links to GitHub/Jira/Slack/etc. -->

## Description

<!-- Describe what this PR changes. -->
<!-- Write a brief description of this PR. -->

## Related links

## Review Procedure
<!-- Write the links related to this PR. -->

<!-- Explain how to review this PR. -->
## Tests performed

## Remarks
<!-- Describe how you have tested this PR. -->

<!-- Write remarks as you like if you need them. -->
## Notes for reviewers

## Pre-Review Checklist for the PR Author
<!-- Write additional information if necessary. It should be written if there are related PRs that should be merged at the same time. -->

**PR Author should check the checkboxes below when creating the PR.**
## Pre-review checklist for the PR author

- [ ] Code follows [coding guidelines][coding-guidelines]
- [ ] Assign PR to reviewer
The PR author **must** check the checkboxes below when creating the PR.

## Checklist for the PR Reviewer
- [ ] I've confirmed the [contribution guidelines].
- [ ] The PR follows the [pull request guidelines].

**Reviewers should check the checkboxes below before approval.**
## In-review checklist for the PR reviewers

- [ ] Commits are properly organized and messages are according to the guideline
- [ ] Code follows [coding guidelines][coding-guidelines]
- [ ] (Optional) Unit tests have been written for new behavior
- [ ] PR title describes the changes
The PR reviewers **must** check the checkboxes below before approval.

## Post-Review Checklist for the PR Author
- [ ] The PR follows the [pull request guidelines].
- [ ] The PR has been properly tested.
- [ ] The PR has been reviewed by the code owners.

**PR Author should check the checkboxes below before merging.**
## Post-review checklist for the PR author

- [ ] All open points are addressed and tracked via issues or tickets
- [ ] Write [release notes][release-notes]
The PR author **must** check the checkboxes below before merging.

## CI Checks
- [ ] There are no open discussions or they are tracked via tickets.
- [ ] The PR is ready for merge.

- **Build and test for PR**: Required to pass before the merge.
- **Check spelling**: NOT required to pass before the merge. It is up to the reviewer(s). See [here][spell-check-dict] if you want to add some words to the spell check dictionary.
After all checkboxes are checked, anyone who has write access can merge the PR.

[coding-guidelines]: https://tier4.atlassian.net/wiki/spaces/AIP/pages/1194394777/T4
[release-notes]: https://tier4.atlassian.net/l/c/X1p69s6B
[spell-check-dict]: https://github.com/tier4/autoware-spell-check-dict#how-to-contribute
[contribution guidelines]: https://autowarefoundation.github.io/autoware-documentation/main/contributing/
[pull request guidelines]: https://autowarefoundation.github.io/autoware-documentation/main/contributing/pull-request-guidelines/