Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dr-autosync: Should not change replication mode from sync_recover to async after recover backup cluster #4737

Closed
mayjiang0203 opened this issue Mar 16, 2022 · 1 comment · Fixed by #4738
Closed

dr-autosync: Should not change replication mode from sync_recover to async after recover backup cluster #4737

mayjiang0203 opened this issue Mar 16, 2022 · 1 comment · Fixed by #4738
Assignees
@disksing
Labels
severity/moderate type/bug The issue is confirmed as a bug.

Comments

@mayjiang0203
Copy link

Bug Report

What did you do?

1、Down backup cluster;
2、Restart backup cluster until dr replication mode change to sync_recover
3、Down primary cluster, recover the backup cluster via pd-recover;
4、Restart backup cluster, check DR_STATE, found it change to async.

What did you expect to see?

In step 4, should stay in sync_recover , because primary cluster has been down.

What did you see instead?

mN8ZdpUKkM

What version of PD are you using (pd-server -V)?

sh-4.2# /tiup/deploy/pd-2379/bin/pd-server -version
Release Version: v6.0.0-alpha
Edition: Community
Git Commit Hash: d56b195
Git Branch: heads/refs/tags/v6.0.0-alpha
UTC Build Time: 2022-03-12 02:52:06
@mayjiang0203 mayjiang0203 added the type/bug The issue is confirmed as a bug. label Mar 16, 2022
@mayjiang0203 mayjiang0203 changed the title dr-autosync: Should not change replicate from sync_recover to async after recover backup cluster dr-autosync: Should not change replication mode from sync_recover to async after recover backup cluster Mar 16, 2022
@mayjiang0203
Copy link
Author

/type bug
/severity moderate
/assign disksing

disksing added a commit to oh-my-tidb/pd that referenced this issue Mar 16, 2022
@disksing
dr-autosync: do not switch to async when there is not enough peers
e095809 
fix tikv#4737

Signed-off-by: disksing <i@disksing.com>
@disksing disksing mentioned this issue Mar 16, 2022
Merged
ti-chi-bot added a commit that referenced this issue Mar 17, 2022
@disksing @ti-chi-bot
dr-autosync: do not switch to async when there is not enough peers (#…
950b363 
…4738)

close #4737

Signed-off-by: disksing <i@disksing.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
rleungx pushed a commit to rleungx/pd that referenced this issue Mar 17, 2022
@disksing @ti-chi-bot @rleungx
dr-autosync: do not switch to async when there is not enough peers (t…
d9dba6f 
…ikv#4738)

close tikv#4737

Signed-off-by: disksing <i@disksing.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@disksing disksing

Labels
severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dr-autosync: do not switch to async when there is not enough peers oh-my-tidb/pd
3 participants
@mayjiang0203 @disksing @ti-chi-bot