Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade etcd to v3.4.3 (#2058) #2063

Merged
merged 2 commits into from
Dec 31, 2019
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Dec 30, 2019

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Update etcd to v3.4.3.
Fix:

What is changed and how it works?

update release-3.1

Check List

Tests

  • Unit test
  • Integration test

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added the component/build Build process. label Dec 30, 2019
@codecov-io
Copy link

Codecov Report

Merging #2063 into release-3.1 will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.1    #2063      +/-   ##
===============================================
+ Coverage        69.52%   69.65%   +0.13%     
===============================================
  Files              171      171              
  Lines            16846    16846              
===============================================
+ Hits             11712    11734      +22     
+ Misses            4155     4136      -19     
+ Partials           979      976       -3
Impacted Files Coverage Δ
pkg/metricutil/metricutil.go 86.11% <100%> (ø) ⬆️
server/api/utiletcdhttpapi.go 55.55% <0%> (-22.23%) ⬇️
server/api/diagnose.go 60.34% <0%> (-5.18%) ⬇️
server/grpc_service.go 58.63% <0%> (-2.35%) ⬇️
client/client.go 74.53% <0%> (-0.83%) ⬇️
server/handler.go 51.98% <0%> (+0.49%) ⬆️
server/cluster.go 81.81% <0%> (+0.5%) ⬆️
server/schedule/operator.go 87.58% <0%> (+0.64%) ⬆️
server/statistics/store_collection.go 86.95% <0%> (+1.44%) ⬆️
server/statistics/region_collection.go 91.24% <0%> (+1.45%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 529de48...153876b. Read the comment docs.

@nolouch
Copy link
Contributor Author

nolouch commented Dec 30, 2019

/run-all-tests

Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lhy1024
Copy link
Contributor

lhy1024 commented Dec 31, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2019
@nolouch
Copy link
Contributor Author

nolouch commented Dec 31, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 31, 2019

/run-all-tests

@sre-bot sre-bot merged commit d1d9175 into tikv:release-3.1 Dec 31, 2019
@AndreMouche AndreMouche added this to the v3.1.0-beta.1 milestone Jan 3, 2020
@nolouch nolouch deleted the upgrade-etcd-3.1 branch February 19, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build Build process. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants