config: validate dashboard-address #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
HunDunDM
added
component/config
disksing
approved these changes
Jun 8, 2020
lhy1024
approved these changes
Jun 8, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@HunDunDM merge failed. |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
cherry pick to release-4.0 in PR #2522 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zheng Xiangsheng hundundm@gmail.com
What problem does this PR solve?
What is changed and how it works?
pd-serverconfig, validate thedashboard-addressand reject the incorrect setting.Check List
Tests
Release note