Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana: add some metrics about bucket #5069

Merged
merged 11 commits into from
Jun 1, 2022

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented May 30, 2022

What problem does this PR solve?

add some metrics

Issue Number: Close #5068

What is changed and how does it work?

Check List

Tests

scheduler
image
heartbeat
image
heatbeat distribute
image

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 30, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels May 30, 2022
@ti-chi-bot ti-chi-bot requested review from rleungx and Yisaer May 30, 2022 09:04
@bufferflies
Copy link
Contributor Author

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented May 30, 2022

Visit the grafana server at: http://172.16.5.5:31013, it will last for 5 hours

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #5069 (9b908c4) into master (52dd587) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5069      +/-   ##
==========================================
- Coverage   75.59%   75.45%   -0.14%     
==========================================
  Files         308      308              
  Lines       30378    30378              
==========================================
- Hits        22963    22922      -41     
- Misses       5432     5460      +28     
- Partials     1983     1996      +13     
Flag Coverage Δ
unittests 75.45% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
server/id/id.go 76.19% <0.00%> (-9.53%) ⬇️
pkg/cache/lru.go 79.06% <0.00%> (-9.31%) ⬇️
server/election/lease.go 84.05% <0.00%> (-4.35%) ⬇️
server/storage/hot_region_storage.go 78.14% <0.00%> (-3.28%) ⬇️
server/tso/allocator_manager.go 60.56% <0.00%> (-2.83%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
server/config/persist_options.go 92.00% <0.00%> (-1.82%) ⬇️
server/region_syncer/client.go 84.32% <0.00%> (-1.50%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52dd587...9b908c4. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 31, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 1, 2022
metrics/grafana/pd.json Outdated Show resolved Hide resolved
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9b908c4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/needs-triage-completed labels Jun 1, 2022
@ti-chi-bot ti-chi-bot merged commit 1fa1d4f into tikv:master Jun 1, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5082.

ti-chi-bot added a commit that referenced this pull request Jun 1, 2022
close #5068, ref #5069

Signed-off-by: bufferflies <1045931706@qq.com>

Co-authored-by: bufferflies <1045931706@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some metrics for buckets
6 participants