Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: make evict-slow-trend scheduler can manually modify recovery duration. #7132

Merged
merged 18 commits into from
Oct 12, 2023
Merged

scheduler: make evict-slow-trend scheduler can manually modify recovery duration. #7132

merged 18 commits into from
Oct 12, 2023

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Sep 21, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #7156 , Ref tikv/tikv#15271

What is changed and how does it work?

With this pr, users can manually modify the minimal recovery time when encountering an I/O jitter case.

That is, only when the jitter is disappear and the recovery time reach this limit, 
can the given slow node be mark with normal for balancing leaders to it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 21, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

Hi @LykxSassinator. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Merging #7132 (e79d25f) into master (873212f) will increase coverage by 0.06%.
Report is 1 commits behind head on master.
The diff coverage is 88.75%.

@@            Coverage Diff             @@
##           master    #7132      +/-   ##
==========================================
+ Coverage   74.63%   74.70%   +0.06%     
==========================================
  Files         442      442              
  Lines       47596    47660      +64     
==========================================
+ Hits        35523    35603      +80     
+ Misses       8965     8943      -22     
- Partials     3108     3114       +6
Flag Coverage Δ
unittests 74.70% <88.75%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@LykxSassinator LykxSassinator marked this pull request as ready for review September 25, 2023 07:04
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2023
nolouch
nolouch approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

pkg/schedule/schedulers/evict_slow_trend.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 26, 2023
nolouch
nolouch reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a reference to the issue.

@LykxSassinator
Copy link
Contributor Author

LykxSassinator commented Sep 26, 2023 •
edited
Loading

need a reference to the issue.

Got it.

@LykxSassinator
Add annotations for RecoveryDurationGap.
a2e5fa7 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Copy link
Contributor Author

/cc @bufferflies PTAL, thx

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 12, 2023
@bufferflies
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 12, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 12, 2023

This pull request has been accepted and is ready to merge.

Commit hash: e79d25f

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 12, 2023
@rleungx
Copy link
Member

rleungx commented Oct 12, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Oct 12, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0adb86f into tikv:master Oct 12, 2023
26 checks passed
@LykxSassinator LykxSassinator deleted the config_recover_gap branch October 12, 2023 10:27
@LykxSassinator LykxSassinator mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@bufferflies bufferflies bufferflies approved these changes

@lhy1024 lhy1024 Awaiting requested review from lhy1024

Assignees
No one assigned
Labels
ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LykxSassinator @bufferflies @rleungx @nolouch