Skip to content

Conversation

@Justinon
Copy link
Contributor

Adds abstract Shard class for consumers to extend so name functionality can be standardized and abstracted.
Adds UTs for Shard abstract class.

@Justinon Justinon requested a review from a team October 25, 2022 22:10
@Justinon Justinon enabled auto-merge (squash) October 25, 2022 22:10
Justinon and others added 2 commits October 25, 2022 15:19
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #3 (2bfcb38) into main (b0c3262) will increase coverage by 20.33%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             main        #3       +/-   ##
============================================
+ Coverage   79.66%   100.00%   +20.33%     
============================================
  Files           3         3               
  Lines         118       137       +19     
  Branches        4         2        -2     
============================================
+ Hits           94       137       +43     
+ Misses         24         0       -24     
Impacted Files Coverage Δ
src/Shard.ts 100.00% <100.00%> (+100.00%) ⬆️
src/index.ts 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c3262...2bfcb38. Read the comment docs.

@Justinon Justinon merged commit 9794cfc into main Oct 25, 2022
@Justinon Justinon deleted the Justin-Glommen/CLK-187171/Open-Source-NamedEnvs-for-CDK branch October 25, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants