From 09e9c9e51161c7def045fc664d0342fb12e96103 Mon Sep 17 00:00:00 2001 From: JLockerman Date: Mon, 18 Apr 2022 12:13:21 -0400 Subject: [PATCH 1/2] Remove GUC We not longer use this now that we've removed the warning. --- extension/src/lib.rs | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/extension/src/lib.rs b/extension/src/lib.rs index d74098dd..da7914ef 100644 --- a/extension/src/lib.rs +++ b/extension/src/lib.rs @@ -34,19 +34,9 @@ use pgx::*; pgx::pg_module_magic!(); -static EXPERIMENTAL_ENABLED: GucSetting = GucSetting::new(false); - #[pg_guard] pub extern "C" fn _PG_init() { - GucRegistry::define_bool_guc( - "timescaledb_toolkit_acknowledge_auto_drop", - "enable creation of auto-dropping objects using experimental timescaledb_toolkit_features", - "experimental features are very unstable, and objects \ - depending on them will be automatically deleted on extension update", - &EXPERIMENTAL_ENABLED, - //TODO should this be superuser? - GucContext::Userset, - ); + // Nothing to do here } extension_sql!(r#"GRANT USAGE ON SCHEMA toolkit_experimental TO PUBLIC;"#, From a41eabef98bd933aa261ff5cc1fa7226926671cc Mon Sep 17 00:00:00 2001 From: Ryan Walker Date: Mon, 18 Apr 2022 16:17:46 -0400 Subject: [PATCH 2/2] remove setting timescaledb_toolkit_acknowledge_auto_drop also remove a drop and reconnect sequence from the testrunner --- docs/timeseries.md | 5 ----- docs/timeseries_pipeline_elements.md | 1 - extension/src/frequency.rs | 15 --------------- extension/src/time_series/pipeline.rs | 2 -- extension/src/time_series/pipeline/aggregation.rs | 12 ------------ extension/src/time_series/pipeline/arithmetic.rs | 2 -- extension/src/time_series/pipeline/delta.rs | 1 - extension/src/time_series/pipeline/expansion.rs | 3 --- extension/src/time_series/pipeline/fill_holes.rs | 1 - extension/src/time_series/pipeline/fill_to.rs | 1 - extension/src/time_series/pipeline/filter.rs | 1 - extension/src/time_series/pipeline/lambda.rs | 6 ------ extension/src/time_series/pipeline/map.rs | 5 ----- .../src/time_series/pipeline/resample_to_rate.rs | 1 - extension/src/time_series/pipeline/sort.rs | 1 - tools/update-tester/src/testrunner.rs | 6 ------ 16 files changed, 63 deletions(-) diff --git a/docs/timeseries.md b/docs/timeseries.md index 5615d797..7dd28f03 100644 --- a/docs/timeseries.md +++ b/docs/timeseries.md @@ -31,11 +31,6 @@ INSERT INTO test INSERT 0 4032 ``` -While still expermental, we'll need to set this before creating our view: -```SQL , non-transactional,ignore-output - SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'; -``` - Now lets capture this data into a time series which we'll store in a view. ```SQL ,non-transactional,ignore-output diff --git a/docs/timeseries_pipeline_elements.md b/docs/timeseries_pipeline_elements.md index fb7c6e8f..0ce262ea 100644 --- a/docs/timeseries_pipeline_elements.md +++ b/docs/timeseries_pipeline_elements.md @@ -47,7 +47,6 @@ INSERT INTO test_data Now suppose we want to know how much the temperature fluctuates on a daily basis for each device. Using timevector and pipelines can simplify the process of finding the answer: ```SQL ,non-transactional,ignore-output -SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'; CREATE VIEW daily_delta AS SELECT device, toolkit_experimental.timevector(time, temperature) diff --git a/extension/src/frequency.rs b/extension/src/frequency.rs index f17eb7a5..020f3cd1 100644 --- a/extension/src/frequency.rs +++ b/extension/src/frequency.rs @@ -736,11 +736,6 @@ mod tests { .get_one::() .unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select( - "SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", - None, - None, - ); client.select("SET TIMEZONE to UTC", None, None); client.select( @@ -775,11 +770,6 @@ mod tests { .get_one::() .unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select( - "SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", - None, - None, - ); client.select("SET TIMEZONE to UTC", None, None); client.select( @@ -1016,11 +1006,6 @@ mod tests { .get_one::() .unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select( - "SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", - None, - None, - ); client.select("SET TIMEZONE to UTC", None, None); client.select( diff --git a/extension/src/time_series/pipeline.rs b/extension/src/time_series/pipeline.rs index 2a54e342..c23e47c3 100644 --- a/extension/src/time_series/pipeline.rs +++ b/extension/src/time_series/pipeline.rs @@ -434,7 +434,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); client.select( "CREATE TABLE lttb_pipe (series timevector)", @@ -544,7 +543,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); let output = client.select( "EXPLAIN (verbose) SELECT timevector('2021-01-01'::timestamptz, 0.1) -> round() -> abs() -> round();", diff --git a/extension/src/time_series/pipeline/aggregation.rs b/extension/src/time_series/pipeline/aggregation.rs index cc5dd502..856c45b1 100644 --- a/extension/src/time_series/pipeline/aggregation.rs +++ b/extension/src/time_series/pipeline/aggregation.rs @@ -722,7 +722,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); // we use a subselect to guarantee order let create_series = "SELECT timevector(time, value) as series FROM \ @@ -751,7 +750,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); let output = client.select( "EXPLAIN (verbose) SELECT \ @@ -785,7 +783,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); // we use a subselect to guarantee order let create_series = "SELECT timevector(time, value) as series FROM \ @@ -814,7 +811,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); let output = client.select( "EXPLAIN (verbose) SELECT \ @@ -847,7 +843,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); // we use a subselect to guarantee order let create_series = "SELECT timevector(time, value) as series FROM \ @@ -876,7 +871,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); let output = client.select( "EXPLAIN (verbose) SELECT \ @@ -909,7 +903,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); // we use a subselect to guarantee order let create_series = "SELECT timevector(time, value) as series FROM \ @@ -938,7 +931,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); let output = client.select( "EXPLAIN (verbose) SELECT \ @@ -971,7 +963,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); // we use a subselect to guarantee order let create_series = "SELECT timevector(time, value) as series FROM \ @@ -1031,7 +1022,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); // we use a subselect to guarantee order let create_series = "SELECT timevector(time, value) as series FROM \ @@ -1095,7 +1085,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); // we use a subselect to guarantee order let create_series = "SELECT timevector(time, value) as series FROM \ @@ -1141,7 +1130,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); let output = client.select( "EXPLAIN (verbose) SELECT \ diff --git a/extension/src/time_series/pipeline/arithmetic.rs b/extension/src/time_series/pipeline/arithmetic.rs index cf694025..08fc9f07 100644 --- a/extension/src/time_series/pipeline/arithmetic.rs +++ b/extension/src/time_series/pipeline/arithmetic.rs @@ -280,7 +280,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); // we use a subselect to guarantee order let create_series = "SELECT timevector(time, value) as series FROM \ @@ -406,7 +405,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); // we use a subselect to guarantee order let create_series = "SELECT timevector(time, value) as series FROM \ diff --git a/extension/src/time_series/pipeline/delta.rs b/extension/src/time_series/pipeline/delta.rs index 9b3e9811..47f2223d 100644 --- a/extension/src/time_series/pipeline/delta.rs +++ b/extension/src/time_series/pipeline/delta.rs @@ -65,7 +65,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); client.select( "CREATE TABLE series(time timestamptz, value double precision)", diff --git a/extension/src/time_series/pipeline/expansion.rs b/extension/src/time_series/pipeline/expansion.rs index e69713a1..d9667de2 100644 --- a/extension/src/time_series/pipeline/expansion.rs +++ b/extension/src/time_series/pipeline/expansion.rs @@ -184,7 +184,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); // we use a subselect to guarantee order let create_series = "SELECT timevector(time, value) as series FROM \ @@ -215,7 +214,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); // we use a subselect to guarantee order let create_series = "SELECT timevector(time, value) as series FROM \ @@ -244,7 +242,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); // `-> materialize()` should force materialization, but otherwise the // pipeline-folding optimization should proceed diff --git a/extension/src/time_series/pipeline/fill_holes.rs b/extension/src/time_series/pipeline/fill_holes.rs index 462834f8..66954283 100644 --- a/extension/src/time_series/pipeline/fill_holes.rs +++ b/extension/src/time_series/pipeline/fill_holes.rs @@ -127,7 +127,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); client.select( "CREATE TABLE gappy_series(time timestamptz, value double precision)", diff --git a/extension/src/time_series/pipeline/fill_to.rs b/extension/src/time_series/pipeline/fill_to.rs index 6511816c..d3af391f 100644 --- a/extension/src/time_series/pipeline/fill_to.rs +++ b/extension/src/time_series/pipeline/fill_to.rs @@ -129,7 +129,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); client.select( "CREATE TABLE series(time timestamptz, value double precision)", diff --git a/extension/src/time_series/pipeline/filter.rs b/extension/src/time_series/pipeline/filter.rs index ca5114a4..ae4f69c3 100644 --- a/extension/src/time_series/pipeline/filter.rs +++ b/extension/src/time_series/pipeline/filter.rs @@ -84,7 +84,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); client.select( "CREATE TABLE series(time timestamptz, value double precision)", diff --git a/extension/src/time_series/pipeline/lambda.rs b/extension/src/time_series/pipeline/lambda.rs index 360f79d4..30561208 100644 --- a/extension/src/time_series/pipeline/lambda.rs +++ b/extension/src/time_series/pipeline/lambda.rs @@ -552,7 +552,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); client.select("SELECT $$ let $1 = 1.0; 2.0, $1 $$::toolkit_experimental.lambda", None, None); // client.select("SELECT $$ '1 day'i $$::toolkit_experimental.lambda", None, None); // client.select("SELECT $$ '2020-01-01't $$::toolkit_experimental.lambda", None, None); @@ -625,7 +624,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); bool_lambda_eq!(client, "2.0 < 3.0", "true"); bool_lambda_eq!(client, "2.0 <= 3.0", "true"); @@ -666,7 +664,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); f64_lambda_eq!(client, "pi()", std::f64::consts::PI); @@ -707,7 +704,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); f64_lambda_eq!(client, "-(2.0)", -2.0f64); f64_lambda_eq!(client, "-(-2.0)", 2.0f64); @@ -729,7 +725,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); interval_lambda_eq!(client, "'1 day'i + '1 day'i", "2 days"); interval_lambda_eq!(client, "'1 day'i + '1 week'i", "8 days"); @@ -749,7 +744,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); f64_lambda_eq!(client, "let $foo = 2.0; $foo", 2.0); f64_lambda_eq!(client, "let $foo = -2.0; $foo", -2.0); diff --git a/extension/src/time_series/pipeline/map.rs b/extension/src/time_series/pipeline/map.rs index e1471595..4d770b43 100644 --- a/extension/src/time_series/pipeline/map.rs +++ b/extension/src/time_series/pipeline/map.rs @@ -338,7 +338,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); client.select( "CREATE TABLE series(time timestamptz, value double precision)", @@ -397,7 +396,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); client.select( "CREATE TABLE series(time timestamptz, value double precision)", @@ -472,7 +470,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); client.select( "CREATE TABLE series(time timestamptz, value double precision)", @@ -538,7 +535,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); client.select( "CREATE TABLE series(time timestamptz, value double precision)", @@ -611,7 +607,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); client.select( "CREATE TABLE series(time timestamptz, value double precision)", diff --git a/extension/src/time_series/pipeline/resample_to_rate.rs b/extension/src/time_series/pipeline/resample_to_rate.rs index 4bfac9d4..1859a652 100644 --- a/extension/src/time_series/pipeline/resample_to_rate.rs +++ b/extension/src/time_series/pipeline/resample_to_rate.rs @@ -236,7 +236,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); client.select( "CREATE TABLE resample_pipe (series timevector)", diff --git a/extension/src/time_series/pipeline/sort.rs b/extension/src/time_series/pipeline/sort.rs index 70140643..9a4907e3 100644 --- a/extension/src/time_series/pipeline/sort.rs +++ b/extension/src/time_series/pipeline/sort.rs @@ -51,7 +51,6 @@ mod tests { // difficult to spot otherwise. let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::().unwrap(); client.select(&format!("SET LOCAL search_path TO {}", sp), None, None); - client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None); client.select( "CREATE TABLE series(time timestamptz, value double precision)", diff --git a/tools/update-tester/src/testrunner.rs b/tools/update-tester/src/testrunner.rs index bdb482f4..c86ab152 100644 --- a/tools/update-tester/src/testrunner.rs +++ b/tools/update-tester/src/testrunner.rs @@ -35,12 +35,6 @@ pub fn run_update_tests( let validation_values = test_client.create_test_objects_for(&old_version); - // TODO old versions require a new connection for updates. - // we can fix this by dropping our guc, - // at which point this can be deleted - drop(test_client); - test_client = connect_to(&test_config); - test_client.update_to_current_version(); let new_version = test_client.get_installed_extension_version(); assert_eq!(