Add support for DROP SCHEMA on multi-node #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmwkaa
requested review from
berkley,
mkindahl and
svenklemm
and removed request for
a team
pmwkaa
force-pushed
the
dist_drop_schema
branch
from
02e7bad
to
802dd24
Compare
Codecov Report
@@ Coverage Diff @@
## master #3949 +/- ##
==========================================
- Coverage 90.74% 90.73% -0.01%
==========================================
Files 213 213
Lines 38459 38466 +7
==========================================
+ Hits 34898 34904 +6
- Misses 3561 3562 +1
Continue to review full report at Codecov.
|
akuzm
reviewed
Dec 22, 2021
Comment on lines
+371
to
373
| /* For DROP TABLE and DROP SCHEMA operations hypertable_list will be empty */ | ||
| if (list_length(args->hypertable_list) == 0) | ||
| { |
There was a problem hiding this comment.
If the hypertable_list is not empty, and removeType == OBJECT_TABLE, what would that mean?
There was a problem hiding this comment.
Or what does the default branch in the following switch/case means... looks like this needs more assertions/comments.
There was a problem hiding this comment.
I believe hypertable can't be added into the hypertable list, because drop operation is already happened by PostgreSQL standard hook (src/process_utility.c) at this point and it can't be resolved
There was a problem hiding this comment.
Should it be an Assert then, with this explanation as a comment?
akuzm
reviewed
Dec 22, 2021
Comment on lines
+381
to
+382
| /* Forward DROP SCHEMA command to all data nodes, following | ||
| * sql_drop events will be ignored */ |
There was a problem hiding this comment.
A completely clueless question: why do we have to execute DROP SCHEMA immediately, in contrast to DROP TABLE?
There was a problem hiding this comment.
Previously we did not support CREATE SCHEMA explicitly on data nodes and whenDROP SCHEMA CASCADE was executed, we only shipped it by analyzing distributed hypertables which we part of that schema. No it is much simpler, we assume schema exists on all data nodes and we can drop it right away.
akuzm
approved these changes
Dec 22, 2021
afiskon
approved these changes
Dec 22, 2021
erimatnor
approved these changes
Dec 22, 2021
This PR changes logic and allows DROP SCHEMA command to be executed on each data node, even if the schema being dropped has no distributed hypertables in it. Fix: timescale#3909
pmwkaa
force-pushed
the
dist_drop_schema
branch
from
802dd24
to
894c004
Compare
akuzm
added a commit
to akuzm/timescaledb
that referenced
this pull request
Feb 17, 2022
This release is medium priority for upgrade. We recommend that you upgrade at the next available opportunity. This release adds major new features since the 2.5.2 release, including: Compression in continuous aggregates Experimental support for timezones in continuous aggregates Experimental support for monthly buckets in continuous aggregates It also includes several bug fixes. Telemetry reports are switched to a new format, and now include more detailed statistics on compression, distributed hypertables and indexes. **Features** * timescale#3768 Allow ALTER TABLE ADD COLUMN with DEFAULT on compressed hypertable * timescale#3769 Allow ALTER TABLE DROP COLUMN on compressed hypertable * timescale#3943 Optimize first/last * timescale#3945 Add support for ALTER SCHEMA on multi-node * timescale#3949 Add support for DROP SCHEMA on multi-node **Bugfixes** * timescale#3808 Properly handle max_retries option * timescale#3863 Fix remote transaction heal logic * timescale#3869 Fix ALTER SET/DROP NULL contstraint on distributed hypertable * timescale#3944 Fix segfault in add_compression_policy * timescale#3961 Fix crash in EXPLAIN VERBOSE on distributed hypertable * timescale#4015 Eliminate float rounding instabilities in interpolate * timescale#4019 Update ts_extension_oid in transitioning state * timescale#4073 Fix buffer overflow in partition scheme **Improvements** Query planning performance is improved for hypertables with a large number of chunks. **Thanks** * @fvannee for reporting a first/last memory leak * @mmouterde for reporting an issue with floats and interpolate
akuzm
added a commit
that referenced
this pull request
Feb 17, 2022
This release is medium priority for upgrade. We recommend that you upgrade at the next available opportunity. This release adds major new features since the 2.5.2 release, including: Compression in continuous aggregates Experimental support for timezones in continuous aggregates Experimental support for monthly buckets in continuous aggregates It also includes several bug fixes. Telemetry reports are switched to a new format, and now include more detailed statistics on compression, distributed hypertables and indexes. **Features** * #3768 Allow ALTER TABLE ADD COLUMN with DEFAULT on compressed hypertable * #3769 Allow ALTER TABLE DROP COLUMN on compressed hypertable * #3943 Optimize first/last * #3945 Add support for ALTER SCHEMA on multi-node * #3949 Add support for DROP SCHEMA on multi-node **Bugfixes** * #3808 Properly handle max_retries option * #3863 Fix remote transaction heal logic * #3869 Fix ALTER SET/DROP NULL contstraint on distributed hypertable * #3944 Fix segfault in add_compression_policy * #3961 Fix crash in EXPLAIN VERBOSE on distributed hypertable * #4015 Eliminate float rounding instabilities in interpolate * #4019 Update ts_extension_oid in transitioning state * #4073 Fix buffer overflow in partition scheme **Improvements** Query planning performance is improved for hypertables with a large number of chunks. **Thanks** * @fvannee for reporting a first/last memory leak * @mmouterde for reporting an issue with floats and interpolate
svenklemm
pushed a commit
that referenced
this pull request
Feb 17, 2022
This release is medium priority for upgrade. We recommend that you upgrade at the next available opportunity. This release adds major new features since the 2.5.2 release, including: Compression in continuous aggregates Experimental support for timezones in continuous aggregates Experimental support for monthly buckets in continuous aggregates It also includes several bug fixes. Telemetry reports are switched to a new format, and now include more detailed statistics on compression, distributed hypertables and indexes. **Features** * #3768 Allow ALTER TABLE ADD COLUMN with DEFAULT on compressed hypertable * #3769 Allow ALTER TABLE DROP COLUMN on compressed hypertable * #3943 Optimize first/last * #3945 Add support for ALTER SCHEMA on multi-node * #3949 Add support for DROP SCHEMA on multi-node **Bugfixes** * #3808 Properly handle max_retries option * #3863 Fix remote transaction heal logic * #3869 Fix ALTER SET/DROP NULL contstraint on distributed hypertable * #3944 Fix segfault in add_compression_policy * #3961 Fix crash in EXPLAIN VERBOSE on distributed hypertable * #4015 Eliminate float rounding instabilities in interpolate * #4019 Update ts_extension_oid in transitioning state * #4073 Fix buffer overflow in partition scheme **Improvements** Query planning performance is improved for hypertables with a large number of chunks. **Thanks** * @fvannee for reporting a first/last memory leak * @mmouterde for reporting an issue with floats and interpolate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes logic and allows DROP SCHEMA command to be executed
on each data node, even if the schema being dropped has no distributed
hypertables in it.
Fix: #3909