Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish registering packages #5

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Finish registering packages #5

merged 1 commit into from
Dec 16, 2022

Conversation

timholy
Copy link
Owner

@timholy timholy commented Dec 16, 2022

Previously the loaded cache files were "unfinished," and need to call
module initialization etc. This depends on
JuliaLang/julia#47184
to provide a convenient utility for finalizing these modules.

Previously the loaded cache files were "unfinished," and need to call
module initialization etc. This depends on
JuliaLang/julia#47184
to provide a convenient utility for finalizing these modules.
@timholy
Copy link
Owner Author

timholy commented Dec 16, 2022

Even though the Julia functionality isn't merged, I will go ahead and merge this because this package (unreleased) is undergoing pretty heavy development right now and I don't want to be slowed down by lots of branch-merging to build something functional.

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 92.68% // Head: 91.66% // Decreases project coverage by -1.01% ⚠️

Coverage data is based on head (5d359e2) compared to base (f8d1d14).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   92.68%   91.66%   -1.02%     
==========================================
  Files           1        1              
  Lines          82       84       +2     
==========================================
+ Hits           76       77       +1     
- Misses          6        7       +1     
Impacted Files Coverage Δ
src/PkgCacheInspector.jl 91.66% <50.00%> (-1.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timholy timholy merged commit 164812f into main Dec 16, 2022
@timholy timholy deleted the teh/register branch December 16, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant