Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadableStreamReadResult used in grpc-web-format.d.ts is no longer available type since typescript 4.2 #248

Closed
kskalski opened this issue Mar 12, 2022 · 5 comments

Comments

@kskalski
Copy link
Contributor

Compiling project using grpcweb-transport using latest typescript compiler produces

TS2304 error (TS) Cannot find name 'ReadableStreamReadResult'.	
in node_modules\@protobuf-ts\grpcweb-transport\build\types\grpc-web-format.d.ts

This is caused by a breaking change in typescript types microsoft/TypeScript#42970
and a fix is to change ReadableStreamReadResult to ReadableStreamDefaultReadResult

@timostamm
Copy link
Owner

Hey Kamil,

could you verify with skipDefaultLibCheck and - in case it is not sufficient, skipLibCheck?

@kskalski
Copy link
Contributor Author

Yes, "skipLibCheck": true, silences this error (skipDefaultLibCheck doesn't).

timostamm added a commit that referenced this issue Mar 15, 2022
@timostamm
Copy link
Owner

Thank you. This seems worth a workaround.

A fix is released in a pre-release version. Can you confirm that @protobuf-ts/grpcweb-transport@2.2.3-alpha.1 fixes the issue?

@kskalski
Copy link
Contributor Author

Thanks, it fixes the issue.

@timostamm
Copy link
Owner

Fix released in v2.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants