From 8be145f7e3918be69f158bd9f07b918ed1bbafce Mon Sep 17 00:00:00 2001 From: James Wyatt Cready-Pyle Date: Mon, 27 Jan 2025 14:44:06 -0500 Subject: [PATCH] Read unknown fields even on empty messages --- .../internal-binary-read.ts | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/packages/plugin/src/message-type-extensions/internal-binary-read.ts b/packages/plugin/src/message-type-extensions/internal-binary-read.ts index 0b827e90..0e5178e7 100644 --- a/packages/plugin/src/message-type-extensions/internal-binary-read.ts +++ b/packages/plugin/src/message-type-extensions/internal-binary-read.ts @@ -34,21 +34,6 @@ export class InternalBinaryRead implements CustomMethodGenerator { make(source: TypescriptFile, descriptor: DescriptorProto): ts.MethodDeclaration[] { const methods: ts.MethodDeclaration[] = []; - // if the message has no fields, we produce a much shorter body: - // return target ?? this.create(); - if (descriptor.field.length === 0) { - return [this.makeMethod(source, descriptor, - ts.createReturn(ts.createBinary( - ts.createIdentifier("target"), - ts.createToken(ts.SyntaxKind.QuestionQuestionToken), - ts.createCall( - ts.createPropertyAccess(ts.createThis(), ts.createIdentifier("create")), - undefined, [] - ) - )) - )]; - } - // internalBinaryRead(reader: IBinaryReader, length: number, options: BinaryReadOptions, target?: ${messageInterfaceId}): ${messageInterfaceId} { let internalBinaryRead = this.makeMethod( source,