Resolved issue esp8266#3359

Made severing connections optional as per the patch in the issue. Also fixed a minor spacing issue.
timstableford · Feb 22, 2020 · e81af05 · e81af05
1 parent bea64df
commit e81af05
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/libraries/ESP8266httpUpdate/src/ESP8266httpUpdate.cpp b/libraries/ESP8266httpUpdate/src/ESP8266httpUpdate.cpp
@@ -345,8 +345,10 @@ HTTPUpdateResult ESP8266HTTPUpdate::handleUpdate(HTTPClient& http, const String&
 
                 WiFiClient * tcp = http.getStreamPtr();
 
-                WiFiUDP::stopAll();
-                WiFiClient::stopAllExcept(tcp);
+                if (_severConnectionsOnUpdate) {
+                    WiFiUDP::stopAll();
+                    WiFiClient::stopAllExcept(tcp);
+                }
 
                 delay(100);
 

diff --git a/libraries/ESP8266httpUpdate/src/ESP8266httpUpdate.h b/libraries/ESP8266httpUpdate/src/ESP8266httpUpdate.h
@@ -87,6 +87,11 @@ class ESP8266HTTPUpdate
         _followRedirects = follow;
     }
 
+    void severConnectionsOnUpdate(bool sever)
+    {
+        _severConnectionsOnUpdate = sever;
+    }
+
     void setLedPin(int ledPin = -1, uint8_t ledOn = HIGH)
     {
         _ledPin = ledPin;
@@ -146,12 +151,13 @@ class ESP8266HTTPUpdate
     // Set the error and potentially use a CB to notify the application
     void _setLastError(int err) {
         _lastError = err;
-	if (_cbError) {
+        if (_cbError) {
             _cbError(err);
         }
     }
     int _lastError;
     bool _rebootOnUpdate = true;
+    bool _severConnectionsOnUpdate = true;
 private:
     int _httpClientTimeout;
     bool _followRedirects;