From ab1b234364898a52bad24385e37c8db48d34453c Mon Sep 17 00:00:00 2001 From: Manuel Mendez Date: Thu, 10 Mar 2022 10:49:06 -0500 Subject: [PATCH] tink-cli: Add bash to container image I've recently been bitten by alpine/busybox's ash not properly implementing `[[` as a builtin while doing a bunch of work on sandbox's scripts. Changing over to POSIX sh is an option but not really worth it imo as almost everyone assumes sh == bash already and bash is also nice for interactive use anyway. Bash ends up adding ~2.2MB to the image which I don't think matters, tink-cli isn't going to be used in production all that much and its still pretty small. tink-cli-yes-bash latest 3f59f8e81a34 10 seconds ago 30.4MB tink-cli-no-bash latest e521b3895111 23 seconds ago 28.2MB Signed-off-by: Manuel Mendez --- cmd/tink-cli/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/tink-cli/Dockerfile b/cmd/tink-cli/Dockerfile index 5d59df740..aa3c0f6e9 100644 --- a/cmd/tink-cli/Dockerfile +++ b/cmd/tink-cli/Dockerfile @@ -4,5 +4,5 @@ CMD sleep infinity ARG TARGETARCH ARG TARGETVARIANT -RUN apk add --no-cache --update --upgrade ca-certificates +RUN apk add --no-cache --update --upgrade bash ca-certificates COPY tink-cli-linux-${TARGETARCH:-amd64}${TARGETVARIANT} /usr/bin/tink