Updating format of hardware cli-reference #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
each command is linkable, has usage and example information.
Contributor
|
Hey @DailyAlice, I am doing few changes in the "tink hardware cli" in the code. And in this PR there are lot of changes which needs to be done once my PR will be merged. You can look at following PR for the reference: |
Contributor
Author
|
Nice! Not at all a problem. I can make edits to this PR to catch up. |
DailyAlice
changed the title
Removed `all`, and added new responses for `mac` and `ip` to match tinkerbell/tink#207.
Contributor
Author
|
@parauliya I made the changes to reflect your PR, commit for reference if you want to take a look. When we get the CI stuff passing again we can try to merge these at around the same time. |
thomcrowe
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
each command is linkable, has usage and example information.