Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes + support timezonefinder #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

rokdd
Copy link

@rokdd rokdd commented Jul 26, 2021

  • Some minor fixes (global do_merge not in split function,..)
  • adding support for timezonefinder to find timezone by coordinates offline. (I have a huge file to split over many years in different timezones)
  • timedelta for split not at midnight but for example 4am in morning (because of this the timezone is very important)

rokdd added 3 commits July 26, 2021 16:11
Some minor fixes (global do_merge not in split function,..) and adding support for timezonefinder
timedelta as argument
@rokdd rokdd marked this pull request as ready for review July 27, 2021 19:12
@rokdd
Copy link
Author

rokdd commented Jul 27, 2021

Do you like my ideas or do you would solve some stuff different? I was not sure what should be a argument or just only a constant in the code.

For your background why I changed some stuff. I have a huge file with activities of google of the last 3 years. So I wanted to split them by day but not at midnight, after 4am (because I prefer to sleep at this moment). Because of the missing timezone and splitting by time I added the timezonefinder which also calculated offline the timezone by lat/lon. And last but not least I noticed that all tracks has no names, so after removing duplicates I had only half of the way left over (thats why I introduced the constant to handle this different). And thanks for your great code which works very well and was very understandable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant