Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass argv to child_process #79

Merged
merged 1 commit into from
Jan 7, 2024
Merged

fix: pass argv to child_process #79

merged 1 commit into from
Jan 7, 2024

Conversation

sirenkovladd
Copy link
Member

Fixed: #78

add pass argv
https://github.com/nodejs/node/blob/main/lib/child_process.js#L158
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/child_process.d.ts#L1391

add to parameters options.argv

this.process = fork(
      fileURLToPath(import.meta.url + '/../entry/process.js'),
      options.argv,
      options
    )
  • - add test

@Aslemammad Aslemammad requested a review from AriPerkkio January 7, 2024 08:35
@Aslemammad
Copy link
Member

Thank you so much!

AriPerkkio
AriPerkkio approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@AriPerkkio AriPerkkio merged commit ac2e839 into main Jan 7, 2024
12 checks passed
@AriPerkkio AriPerkkio deleted the fix-child-process-argv branch January 7, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aslemammad Aslemammad Aslemammad approved these changes

@AriPerkkio AriPerkkio AriPerkkio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

process.argv does not work in worker!
3 participants
@sirenkovladd @Aslemammad @AriPerkkio