commit 9bb5735a88842b8f237baf5c41943d4c5fd1a69d Merge: 91ad492a0 e983049e5 Author: Arka Ganguli Date: Mon Aug 26 16:37:23 2019 -0700 Merge branch 'master' of github.com:tinyspeck/vitess into tinyspeck-master commit 91ad492a0007ed699306dab6243604492643b6ce Merge: 335545926 0c48deece Author: Sugu Sougoumarane Date: Mon Aug 26 15:29:50 2019 -0700 Merge pull request #5129 from planetscale/ds-bkup-hchk healthcheck after backup should be run only for offline backups commit 335545926df8a3ce80fa8cbb6db5695fd527ca39 Merge: 6467c9854 c697d32ed Author: Sugu Sougoumarane Date: Mon Aug 26 12:45:44 2019 -0700 Merge pull request #5072 from planetscale/rk-add-expression Addition expression implementation commit c697d32eda8d4911f1cbae358ebd443a2466316c Author: Rasika Kale Date: Mon Aug 26 12:10:33 2019 -0700 - Added fixes from github to ensure code coverage - Deleted Subtract() and Multiply() and other functions not related to Add() Signed-off-by: Rasika Kale go/sqltypes/arithmetic.go commit 6467c985497f0556b9b1b6012e57f26d86b0d941 Merge: d14badef5 2d9254351 Author: Sugu Sougoumarane Date: Sat Aug 24 12:27:45 2019 -0700 Merge pull request #4996 from planetscale/ss-multi-lookup v3: support overlapping multi-column vindexes commit d030531eb7e931876191d6adfa3d8a7c0451fb87 Author: Rasika Kale Date: Fri Aug 23 15:26:31 2019 -0700 - Fixed error in TestAdd() Signed-off-by: Rasika Kale go/sqltypes/arithmetic_test.go commit 25ed9431132c01345b0fa8dda4a2bca1cf43e155 Author: Rasika Kale Date: Fri Aug 23 14:42:44 2019 -0700 - Changed default return value in newNumeric() from Float64 to Int64 Signed-off-by: Rasika Kale go/sqltypes/arithmetic.go commit 0c48deece6d30691842a994f8c96b51c56255184 Author: deepthi Date: Fri Aug 23 11:37:26 2019 -0700 check that actionMutex is locked before running healthcheck Signed-off-by: deepthi go/vt/vttablet/tabletmanager/healthcheck.go commit d14badef5b1f1095058642e10346994c72f03d37 Merge: e9ce17599 2217172f5 Author: Sugu Sougoumarane Date: Fri Aug 23 10:37:00 2019 -0700 Merge pull request #5117 from AllenZMC/patch-1 fix typos in vtbackup.go commit e9ce17599cf580765e7a7e752158b5f2a51d0b29 Merge: 253e3d0c3 e94f297bc Author: Sugu Sougoumarane Date: Fri Aug 23 10:31:41 2019 -0700 Merge pull request #5121 from mpawliszyn/mikepaw.fix-sum-count Empty results should return a count of 0 but a sum of null. commit 253e3d0c38c75ce2a56d24866488f76812bcda6c Merge: 8cbed0969 972d89724 Author: Sugu Sougoumarane Date: Fri Aug 23 10:31:11 2019 -0700 Merge pull request #5126 from hwdef/fix-typo-go/vt/workflow Cleanup: fix some typos in code comment commit 8cbed09697bfa6695ad24d96b1bbe6ec9be9041c Merge: 98a735dbc 51ba11f52 Author: Sugu Sougoumarane Date: Fri Aug 23 10:30:19 2019 -0700 Merge pull request #5127 from hwdef/fix-typo fix spelling mistake commit d221b9cf4b39467e6db2f10fa4f3d75b64f6c846 Author: deepthi Date: Fri Aug 23 10:28:17 2019 -0700 healthcheck after backup should be run only for offline backups Signed-off-by: deepthi go/vt/vttablet/tabletmanager/rpc_backup.go commit 8a009d55d2ba1e414b32eedd4114cebda51368f3 Author: Rasika Kale Date: Fri Aug 23 10:18:57 2019 -0700 - Fixed code from comments given by systay in arithmetic.go Signed-off-by: Rasika Kale go/sqltypes/arithmetic.go commit e94f297bc6c738f50e546e2581248b6c3705fd24 Author: Michael Pawliszyn Date: Wed Aug 21 14:04:12 2019 -0400 Empty results should return a count of 0 but a sum of null. Signed-off-by: Michael Pawliszyn go/vt/vtgate/engine/ordered_aggregate.go go/vt/vtgate/engine/ordered_aggregate_test.go commit 51ba11f52ffcf3ae42876ccfbacf6ec0a2e1cdc7 Author: hwdef Date: Fri Aug 23 13:33:42 2019 +0800 fix spelling mistake Signed-off-by: hwdef go/cmd/vtbackup/vtbackup.go go/mysql/auth_server_static_test.go go/mysql/binlog_event_common.go go/mysql/binlog_event_make.go go/mysql/binlog_event_make_test.go go/mysql/encoding_test.go go/mysql/endtoend/replication_test.go go/mysql/query_test.go go/netutil/conn.go go/vt/automation/scheduler.go go/vt/binlog/binlogplayer/binlog_player.go go/vt/binlog/keyrange_filter.go go/vt/dbconfigs/dbconfigs.go go/vt/discovery/replicationlag.go go/vt/mysqlctl/fakemysqldaemon/fakemysqldaemon.go go/vt/proto/query/query.pb.go go/vt/proto/tabletmanagerservice/tabletmanagerservice.pb.go go/vt/proto/topodata/topodata.pb.go go/vt/proto/vtrpc/vtrpc.pb.go go/vt/sqlannotation/sqlannotation.go go/vt/throttler/max_replication_lag_module.go go/vt/throttler/max_replication_lag_module_test.go go/vt/throttler/replication_lag_cache_test.go go/vt/throttler/throttlerclient/throttlerclient.go go/vt/throttler/throttlerlogz_test.go go/vt/vtctl/vtctl.go go/vt/vtctl/vtctlclient/interface.go go/vt/vtgate/buffer/buffer.go go/vt/vtgate/engine/merge_sort_test.go go/vt/vtgate/executor_stats.go go/vt/vtgate/executor_test.go go/vt/vtgate/planbuilder/select.go go/vt/vtgate/planbuilder/symtab.go go/vt/vtgate/safe_session.go go/vt/vtgate/scatter_conn.go go/vt/vtqueryserver/vtqueryserver.go go/vt/vttablet/endtoend/config_test.go go/vt/vttablet/endtoend/framework/eventcatcher.go go/vt/vttablet/tabletmanager/action_agent.go go/vt/vttablet/tabletmanager/healthcheck.go go/vt/vttablet/tabletmanager/rpc_server.go go/vt/vttablet/tabletmanager/vreplication/engine_test.go go/vt/vttablet/tabletserver/rules/map_test.go go/vt/vttablet/tabletserver/splitquery/equal_splits_algorithm.go go/vt/vttablet/tabletserver/status.go go/vt/vttablet/tabletserver/tabletserver.go go/vt/vttablet/tabletserver/txthrottler/tx_throttler.go go/vt/vttablet/tabletserver/vstreamer/vstreamer.go go/vt/vttime/clock.go go/vt/worker/grpcvtworkerserver/server.go go/vt/worker/key_resolver.go go/vt/worker/legacy_split_clone.go go/vt/worker/multi_split_diff.go go/vt/worker/restartable_result_reader.go go/vt/worker/restartable_result_reader_test.go go/vt/worker/split_clone.go go/vt/worker/split_clone_test.go go/vt/worker/vtworkerclient/interface.go go/vt/workflow/manager_test.go go/vt/workflow/node_test.go go/vt/workflow/resharding/workflow.go go/vt/wrangler/reparent.go commit 972d89724fb5486230880de2f415fe07e7f29c65 Author: hwdef Date: Fri Aug 23 11:26:27 2019 +0800 Cleanup: fix some typos in code comment Signed-off-by: hwdef go/vt/workflow/manager_test.go go/vt/workflow/node_test.go go/vt/workflow/resharding/workflow.go commit 98a735dbccd1b45320030e46648ecd7be9826d84 Merge: b5207f0d5 30d6e0d0a Author: Deepthi Sigireddi Date: Thu Aug 22 16:46:50 2019 -0700 Merge pull request #5111 from planetscale/ss-vrepl-work routing rules: handle corner case in delete commit c23f0d35fa4640cb639a6ff7a0bcf3b90cffa38c Author: Rasika Kale Date: Thu Aug 22 16:22:26 2019 -0700 - Imported "reflect" in ordered_aggregate_test.go Signed-off-by: Rasika Kale go/vt/vtgate/engine/ordered_aggregate_test.go commit 5dbc3169b2bfb5ed10c87330ec477deb232ce603 Merge: b9c1a151c b5207f0d5 Author: Rasika Kale Date: Thu Aug 22 15:44:26 2019 -0700 Merge remote-tracking branch 'origin/master' into rk-add-expression Signed-off-by: Rasika Kale commit b9c1a151c3f901779f91fa50dc4c7e5419a5b517 Author: Rasika Kale Date: Thu Aug 22 14:43:11 2019 -0700 - Fixed TestToFloat64() and TestNewNumeric() in arithmetic_test.go to avoid runtime errors Signed-off-by: Rasika Kale go/sqltypes/arithmetic_test.go commit 1b5e37db66eb3fdfd8b23b8b7aa756349fb4bfc6 Author: Rasika Kale Date: Thu Aug 22 13:32:46 2019 -0700 - Included fixes for code by Sugu and Morgan - Fixed TestOrderedAggregateMergeFail in ordered_aggregate_test.go to return proper value for expressions such as "b + 1" Signed-off-by: Rasika Kale go/sqltypes/arithmetic.go go/sqltypes/arithmetic_test.go go/sqltypes/value.go go/vt/vtgate/engine/ordered_aggregate.go go/vt/vtgate/engine/ordered_aggregate_test.go commit b5207f0d590a8b596a9b465ee378be182459300f Merge: a3b5da7e2 81cd378a8 Author: Sugu Sougoumarane Date: Wed Aug 21 15:46:46 2019 -0700 Merge pull request #5124 from planetscale/tinyspeck-remove-non-standard-keywords-from-show Remove non standard keywords from show commit 81cd378a85e1ca4bb2955a3af2ac0fbe91ac7718 Merge: 08650b54c 33188c7d8 Author: Saif Alharthi Date: Wed Aug 21 14:06:19 2019 -0700 Fix Merge conflicts Signed-off-by: Saif Alharthi commit a3b5da7e22e63d56e3b6100354c0fffe9431c704 Merge: 08650b54c 613b4cef6 Author: Sugu Sougoumarane Date: Wed Aug 21 13:35:41 2019 -0700 Merge pull request #5114 from planetscale/ss-vrepl-fix-copy vreplication: bug: make row streaming more robust commit cf5f4b9bd3795823a4321d4435a7736818795bc5 Author: Rasika Kale Date: Tue Aug 20 15:26:29 2019 -0700 - Pushing current changes to ordered_aggregate_test.go and arithmetic.go Signed-off-by: Rasika Kale go/sqltypes/arithmetic.go go/vt/vtgate/engine/ordered_aggregate.go go/vt/vtgate/engine/ordered_aggregate_test.go commit 08650b54c6e3bbc63c0b869e4a9fc38c5cd094e4 Merge: cbf78ca90 ad339533f Author: Sugu Sougoumarane Date: Tue Aug 20 13:24:19 2019 -0700 Merge pull request #4936 from planetscale/tj-vtclient vtclient: Add sequential id generation and throttling commit cbf78ca90b2e2b5dbba5e6d03517951712c39c5a Merge: 4441b0ac4 63456f679 Author: Sugu Sougoumarane Date: Tue Aug 20 13:20:59 2019 -0700 Merge pull request #5017 from mpawliszyn/mikepaw.update-golang Updating to golang 1.12 commit 63456f67908d80cce800a015567dbe390ca392ff Author: Michael Pawliszyn Date: Wed Jul 24 11:03:52 2019 -0400 Updating to golang 1.12 Signed-off-by: Michael Pawliszyn .travis.yml docker/bootstrap/Dockerfile.common test/cluster/keytar/config/vitess_config.yaml vagrant-scripts/bootstrap_vm.sh commit 2217172f5f104d194ad85fc501f3f98188cf48a5 Author: AllenZMC Date: Tue Aug 20 21:19:15 2019 +0800 fix typos in vtbackup.go Signed-off-by: 常仲民@daocloud go/cmd/vtbackup/vtbackup.go commit 4441b0ac462d459c3bb52da912eeec6281fb329d Merge: 6684246ba ecc2e8b71 Author: Derek Perkins Date: Mon Aug 19 20:49:31 2019 -0600 Merge pull request #5115 from nozzle/delete-sock-lock helm: delete mysql.sock.lock in init container commit ecc2e8b71e3fa13ba9be5d98b5c09758ba573a49 Author: Derek Perkins Date: Mon Aug 19 19:04:11 2019 -0600 helm: delete mysql.sock.lock in init container Signed-off-by: Derek Perkins helm/vitess/templates/_vttablet.tpl commit 613b4cef60dbb792634ac05297c801981227c96e Author: Sugu Sougoumarane Date: Mon Aug 19 12:49:52 2019 -0700 vreplication: bug: make row streaming more robust During production testing, we found that there are possibilities that a table lock never gets released when row streaming is requested. We most likely suspect that a grpc send hangs, which keeps the table locked, when eventually causes replication to stall and subsequent row streaming requests to hang. This change refactors the code to make sure that we unlock a table as soon as streaming has started. The previous code unlocked the table only after sending the field info. Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletserver/vstreamer/rowstreamer.go commit 6684246ba66e1c669f9eeb0c943e5e9e95e9f7f8 Merge: 243bedace b78c2a7f6 Author: Sugu Sougoumarane Date: Mon Aug 19 12:16:21 2019 -0700 Merge pull request #5110 from AllenZMC/patch-2 fix mis-spelling in txlogz.go commit 243bedace07f6d9760763fcd9d0a383780e7bdf1 Merge: 8d852ef7f 6ed476e71 Author: Sugu Sougoumarane Date: Mon Aug 19 12:14:24 2019 -0700 Merge pull request #5112 from ethan-daocloud/patch-7 cleanup: engine/insert.go comment fix typo commit 6ed476e71efccfa682ff5313adbd51c93ff4f064 Author: Guangming Wang Date: Mon Aug 19 21:46:54 2019 +0800 cleanup: engine/insert.go comment fix typo Signed-off-by: Guangming Wang go/vt/vtgate/engine/insert.go commit 30d6e0d0a3c133cfebc798597535daa791422841 Author: Sugu Sougoumarane Date: Sun Aug 4 11:15:20 2019 -0700 routing rules: handle corner case in delete Signed-off-by: Sugu Sougoumarane go/vt/topo/vschema.go commit ad339533f369fefe53e4f5e6631af30c37ac6a2b Author: Toliver Jue Date: Mon Aug 19 12:23:18 2019 +0900 fix race condition Signed-off-by: Toliver Jue go/cmd/vtclient/vtclient.go commit b78c2a7f6d9806c368eccdc90f806b9462aab0f1 Author: AllenZMC Date: Sun Aug 18 22:07:22 2019 +0800 fix mis-spelling in txlogz.go Signed-off-by: czm go/vt/vttablet/tabletserver/txlogz.go commit 8d852ef7fa58c7ed868a9c6efa7e224e42ca7b52 Merge: e1f954460 3b770807c Author: Sugu Sougoumarane Date: Sat Aug 17 10:09:26 2019 -0700 Merge pull request #5105 from planetscale/morgo-followup-capabilities Cleanup from capabilities PR commit e1f954460044c980be603374ea419fbac7822197 Merge: b359c101a 35e8803ac Author: Sugu Sougoumarane Date: Sat Aug 17 10:07:26 2019 -0700 Merge pull request #5106 from AllenZMC/patch-1 fix wrong spells in vtprocess.go commit b359c101a03381c2bd857b18114c7af78e4c5e3d Merge: e34746c3f 175cf95ec Author: Sugu Sougoumarane Date: Sat Aug 17 10:07:09 2019 -0700 Merge pull request #5107 from ethan-daocloud/patch-6 cleanup: fix typos in mysql/client.go commit e34746c3ffea4e7330425c5abb650458c946a3e4 Merge: a7983a3e3 24d3d1be8 Author: Sugu Sougoumarane Date: Sat Aug 17 10:06:05 2019 -0700 Merge pull request #5011 from nozzle/message-topics-pseudo-table messages: add support for topics that route inserts to multiple subscriber message tables commit 175cf95ec9a77c51219e36771c2b5d9620329808 Author: Guangming Wang Date: Sat Aug 17 23:27:07 2019 +0800 cleanup: fix typos in mysql/client.go Signed-off-by: Guangming Wang go/mysql/client.go commit 35e8803acbebb080155a628325fa0c2b87367525 Author: AllenZMC Date: Sat Aug 17 17:25:44 2019 +0800 fix wrong spells in vtprocess.go Signed-off-by: czm go/vt/vttest/vtprocess.go commit 3b770807c5631a7896dfa2016384fbd658c98db0 Author: Morgan Tocker Date: Fri Aug 16 21:57:28 2019 -0600 Remove compatibility line, no longer required Signed-off-by: Morgan Tocker build.env commit 24d3d1be8fec36646868335c0e33bfd39d2c3851 Author: Derek Perkins Date: Wed Aug 14 21:47:21 2019 -0600 schema: delay broadcast until end of Reload Signed-off-by: Derek Perkins go/vt/vttablet/tabletserver/schema/engine.go go/vt/vttablet/tabletserver/schema/engine_test.go commit c84cab21308f9cb6b8505e23283ff39fe8ad389f Author: Derek Perkins Date: Wed Jul 31 19:46:42 2019 -0700 messages: rebuild topics on every table Reload Signed-off-by: Derek Perkins go/vt/vttablet/tabletserver/schema/engine.go commit f6a162adbcbdb5d30bce27cb35fe7df87cf7f11a Author: Derek Perkins Date: Sun Jul 28 16:42:12 2019 -0700 messages: resolve topic suggestions Signed-off-by: Derek Perkins go/vt/vttablet/tabletserver/planbuilder/dml.go go/vt/vttablet/tabletserver/planbuilder/testdata/exec_cases.txt go/vt/vttablet/tabletserver/schema/load_table.go go/vt/vttablet/tabletserver/tabletserver.go commit 0bf354546d962b361a6b8da2e8ef88e4ba627fe8 Author: Derek Perkins Date: Thu Jul 25 22:19:37 2019 -0600 messages: add topic abstraction like Google PubSub Signed-off-by: Derek Perkins go/vt/vttablet/endtoend/main_test.go go/vt/vttablet/endtoend/message_test.go go/vt/vttablet/tabletserver/planbuilder/dml.go go/vt/vttablet/tabletserver/planbuilder/plan.go go/vt/vttablet/tabletserver/planbuilder/testdata/exec_cases.txt go/vt/vttablet/tabletserver/planbuilder/testdata/schema_test.json go/vt/vttablet/tabletserver/schema/engine.go go/vt/vttablet/tabletserver/schema/load_table.go go/vt/vttablet/tabletserver/schema/load_table_test.go go/vt/vttablet/tabletserver/schema/schema.go go/vt/vttablet/tabletserver/tabletserver.go commit 181aaf3f071b65f373e9ffb5aa6e0b4ae5d948e6 Author: Derek Perkins Date: Thu Jul 25 22:17:47 2019 -0600 schema: add getString from comments Signed-off-by: Derek Perkins go/vt/vttablet/tabletserver/schema/load_table.go commit 56e5b178e54aa895ea4b4143326b7136713abf5f Author: Derek Perkins Date: Sat Jul 20 13:01:10 2019 -0600 endtoend: factor out waitForMessage Signed-off-by: Derek Perkins go/vt/vttablet/endtoend/message_test.go commit a7983a3e3d09db9090fbdf15084730352273d444 Merge: cd686587f 01a30bb3f Author: Sugu Sougoumarane Date: Fri Aug 16 19:37:57 2019 -0700 Merge pull request #5097 from systay/aggregation-distinct-with-empty-input Make sure to handle COUNT and SUM with DISTINCT columns with empty input commit 7097c09234036ba144413b4adaf074dc34e0e73b Author: Morgan Tocker Date: Fri Aug 16 15:36:00 2019 -0600 Add bootstrap Signed-off-by: Morgan Tocker bootstrap.sh commit 604165283dd14bf252086d4e1f60b66d9944f8f3 Merge: d2e0312d0 cd686587f Author: Morgan Tocker Date: Fri Aug 16 15:21:57 2019 -0600 Merge remote-tracking branch 'upstream/master' into morgo-followup-capabilities Signed-off-by: Morgan Tocker commit cd686587f49521a9dfd976e728766e4d6100d391 Merge: 42dc5d898 e370f9a00 Author: Sugu Sougoumarane Date: Fri Aug 16 13:03:50 2019 -0700 Merge pull request #5086 from ethan-daocloud/patch-5 keyspace.go: cleanup typo in error message commit 42dc5d898217dd04d2c03f3b55f712ce14da298a Merge: 8a4bb1146 c031bd6da Author: Sugu Sougoumarane Date: Fri Aug 16 13:03:09 2019 -0700 Merge pull request #5094 from kalfonso/kalfonso.190814-alter-vschema-add-autoinc Allow adding autoincrement column via "ALTER VSCHEMA..." statement commit 8a4bb1146716cf1d67c845a4f55228a3a5e59bde Merge: 2113547df 476cf9e23 Author: Sugu Sougoumarane Date: Fri Aug 16 13:01:01 2019 -0700 Merge pull request #5100 from AllenZMC/patch-2 fix wrong spells in slave_connection.go commit d2e0312d0e40237e06083717896a35a5b770e11d Author: Morgan Tocker Date: Fri Aug 16 09:52:21 2019 -0600 Cleanup from capabilities PR Signed-off-by: Morgan Tocker build.env go/vt/mysqlctl/capabilityset.go go/vt/mysqlctl/mysqld.go commit 2113547dff5dd97dc3931aa83a9e794959ab76ab Merge: 25c2f15cb 9bfe0092d Author: Sugu Sougoumarane Date: Thu Aug 15 16:41:16 2019 -0700 Merge pull request #5093 from planetscale/ss-vrepl-charset vreplication: fix character set issue commit 476cf9e2335dddcb0ff4910a602592eae1a47315 Author: AllenZMC Date: Thu Aug 15 21:17:56 2019 +0800 fix wrong spells in slave_connection.go Signed-off-by: czm go/vt/binlog/slave_connection.go commit 25c2f15cbeaeb7f4a171925a8e8b1b63eead72c1 Author: Anthony Yeh Date: Wed Aug 14 20:53:16 2019 -0700 Auto-detect engine when restoring backups (#5092) * Auto-detect engine when restoring backups Signed-off-by: Anthony Yeh * Add FinishedTime to MANIFEST. Signed-off-by: Anthony Yeh * Store stream mode in xtrabackup MANIFEST. Signed-off-by: Anthony Yeh * Address review comments. Signed-off-by: Anthony Yeh go/cmd/vtbackup/vtbackup.go go/vt/mysqlctl/backup.go go/vt/mysqlctl/backupengine.go go/vt/mysqlctl/builtinbackupengine.go go/vt/mysqlctl/xtrabackupengine.go test/backup.py commit 98305946f5a30bec0236d7452fd6a03b2bba8397 Merge: 1acc4aab7 c51e07f55 Author: Deepthi Sigireddi Date: Wed Aug 14 18:50:19 2019 -0700 Merge pull request #5066 from planetscale/ds-xb-5062 tablet should stay healthy while running xtrabackup commit 1acc4aab79c9d3c39ed58d145841824d58aaf54a Merge: 995ebf6e8 5533c2212 Author: Deepthi Sigireddi Date: Wed Aug 14 16:58:40 2019 -0700 Merge pull request #5096 from planetscale/sa-fix-static-check Address staticcheck warnings in prepared statement commit 5533c2212e5a66a641f4a2cd651628cf315ae447 Author: Saif Alharthi Date: Wed Aug 14 16:20:22 2019 -0700 Address comment Signed-off-by: Saif Alharthi go/mysql/query.go commit c51e07f55892bc3390ac26ebbf1af499a71f8a5e Author: deepthi Date: Wed Aug 14 16:02:53 2019 -0700 export stats for both online and offline backups, use mutex correctly to protect all access to _isBackupRunning and the stats variable Signed-off-by: deepthi go/vt/vttablet/tabletmanager/action_agent.go go/vt/vttablet/tabletmanager/rpc_backup.go commit bfa8482c1e54de3ec3df0c13c5979e0ce39ca401 Author: Saif Alharthi Date: Wed Aug 14 13:00:59 2019 -0700 Quick fix Signed-off-by: Saif Alharthi go/mysql/query.go commit 995ebf6e8b7088209283f4a3687b351c49be56be Merge: 08d588e85 d66ffcdf8 Author: David Weitzman Date: Wed Aug 14 10:16:50 2019 -0700 fix spelling in opentsdb.go (#5095) fix wrong spells in opentsdb.go commit 01a30bb3f407dd95531e23fed936f6434c4ca051 Author: Andres Taylor Date: Wed Aug 14 19:02:41 2019 +0200 Make sure to handle COUNT and SUM with DISTINCT columns Signed-off-by: Andres Taylor go/vt/vtgate/engine/ordered_aggregate.go go/vt/vtgate/engine/ordered_aggregate_test.go commit 53310a35e13b2ee140921f4d9c3956e50f5ada7c Author: Saif Alharthi Date: Wed Aug 14 09:29:54 2019 -0700 Address staticcheck warnings in prepared statement Merged prepared statement code changes did not take into account staticcheck warnings. This PR addresses those warnings. Signed-off-by: Saif Alharthi go/mysql/query.go go/vt/vtgate/executor_dml_test.go commit 0420a592f720c435fb57746f5e74c2c4eb8824fe Author: Andres Taylor Date: Wed Aug 14 17:01:32 2019 +0200 Small test that exposes problem Signed-off-by: Andres Taylor go/vt/vtgate/engine/ordered_aggregate_test.go commit 4dea5a55e867e8b68287f18a34101cb5c6c6036d Author: Andres Taylor Date: Tue Aug 13 10:52:00 2019 +0200 Move one test file to testify Signed-off-by: Andres Taylor go/vt/vtgate/engine/ordered_aggregate_test.go commit a8096931cc7e07092361e8e7c046a0ca7acfae09 Author: Andres Taylor Date: Tue Aug 13 10:38:06 2019 +0200 Update testify dependency Signed-off-by: Andres Taylor vendor/vendor.json commit d66ffcdf8574977caeedaf6925bf3b861075aaa6 Author: AllenZMC Date: Wed Aug 14 21:04:49 2019 +0800 fix wrong spells in opentsdb.go Signed-off-by: czm go/stats/opentsdb/opentsdb.go commit c031bd6dabdd31c1829a109627fa19ba14629051 Author: Karel Alfonso Sague Date: Wed Aug 14 17:16:32 2019 +1000 Allow adding autoincrement column via "ALTER VSCHEMA..." statement Signed-off-by: Karel Alfonso Sague go/vt/sqlparser/ast.go go/vt/sqlparser/parse_test.go go/vt/sqlparser/sql.go go/vt/sqlparser/sql.y go/vt/topotools/vschema_ddl.go go/vt/vtgate/executor.go go/vt/vtgate/executor_test.go commit e370f9a00780f9ad3019f15b1345fdb46f24873b Author: Guangming Wang Date: Tue Aug 13 22:21:32 2019 +0800 keyspace.go: cleanup typo in error message also fix its corresponding test file typos Signed-off-by: Guangming Wang go/vt/topo/keyspace.go go/vt/topo/keyspace_test.go commit 9bfe0092d2345012bfe31b298ce31a3cedad526c Author: Sugu Sougoumarane Date: Sat Aug 3 22:55:32 2019 -0700 vreplication: fix character set issue The latin1 character set performs some conversion, which was not our previous understanding. This changes vreplication to use binary character set instead, which is more faithful about not converting the bits in the database. Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/controller.go go/vt/vttablet/tabletmanager/vreplication/framework_test.go go/vt/vttablet/tabletmanager/vreplication/vplayer_test.go go/vt/vttablet/tabletserver/vstreamer/rowstreamer.go go/vt/vttablet/tabletserver/vstreamer/rowstreamer_test.go commit 08d588e8537e81b68ac7d0e9ba26167d830d2cef Merge: 7149b40c0 77089dbe0 Author: Sugu Sougoumarane Date: Tue Aug 13 20:27:29 2019 -0700 Merge pull request #5080 from kalfonso/kalfonso.190810-alter-vschema-add-sequence-table Allow adding sequence table to the vschema via ALTER VSCHEMA ADD SEQU… commit 7149b40c01d5872bdc66522b0099f81648e2574d Merge: 30f95c97f ed078eb0a Author: Sugu Sougoumarane Date: Tue Aug 13 20:23:28 2019 -0700 Merge pull request #5089 from AllenZMC/patch-1 fix wrong spells in tablet.go commit 30f95c97f8c155f83752445f466007fefb9bfd96 Merge: 4602af693 1a3c80f03 Author: Sugu Sougoumarane Date: Tue Aug 13 20:23:03 2019 -0700 Merge pull request #5091 from planetscale/morgo-move-githooks Move git hooks to start of bootstrap commit 43bb0cfa0a4e58d729437dc883951b76869759da Author: deepthi Date: Tue Aug 13 19:14:30 2019 -0700 add doc for new stats var Signed-off-by: deepthi go/vt/vttablet/tabletmanager/action_agent.go commit 77089dbe0be0fea33a4f1735d0e4785b1a6a6d70 Author: Karel Alfonso Sague Date: Sat Aug 10 10:25:34 2019 +1000 Allow adding sequence table to the vschema via ALTER VSCHEMA ADD SEQUENCE TABLE statement Signed-off-by: Karel Alfonso Sague go/vt/sqlparser/ast.go go/vt/sqlparser/parse_test.go go/vt/sqlparser/sql.go go/vt/sqlparser/sql.y go/vt/sqlparser/token.go go/vt/topotools/vschema_ddl.go go/vt/vtgate/executor.go go/vt/vtgate/executor_test.go commit ac0cdc6d03625e4da5bc35cdb06153aa4f205c59 Author: Rasika Kale Date: Tue Aug 13 15:24:16 2019 -0700 - Changed NullsafeAdd() in ordered_aggregate.go to return only a value, rather than value or error Signed-off-by: Rasika Kale go/vt/vtgate/engine/ordered_aggregate.go commit f526d4795a6977b1ae17441474f1bf9f948937be Author: Rasika Kale Date: Tue Aug 13 13:25:09 2019 -0700 - Deleted functions that are not related to addition expression - Made rk-add-expression only for addition function Signed-off-by: Rasika Kale go/sqltypes/arithmetic.go go/sqltypes/arithmetic_test.go commit 313a830674f917c3f4d4b0ebc9c2bc9640d6555f Author: Rasika Kale Date: Tue Aug 13 13:09:26 2019 -0700 - Fixed code based off comments from Github - Deleted unnecessary comments - Fixed whitespace Signed-off-by: Rasika Kale go/sqltypes/arithmetic.go go/sqltypes/arithmetic_test.go commit 1a3c80f033b5041c6fe26acd00b8221218d300da Author: Morgan Tocker Date: Tue Aug 13 13:53:25 2019 -0600 fix filename in message! Signed-off-by: Morgan Tocker bootstrap.sh commit 5b76ff2eeda44d77eb2d36b933c3adb764a1129a Author: Morgan Tocker Date: Tue Aug 13 13:46:21 2019 -0600 Move git hooks to start of bootstrap. Signed-off-by: Morgan Tocker bootstrap.sh commit 4602af69310e11f1ae44fc46ca9e3e8c03fb7c45 Author: Anthony Yeh Date: Tue Aug 13 12:17:58 2019 -0700 Fix UpdateCellsAlias. (#5090) * Fix UpdateCellsAlias. It should allow updates to an alias that overlap with the previous value of that same alias, since the old value is being replaced. Signed-off-by: Anthony Yeh * Refactor overlappingAlias to validateAlias. To make it more clear which outcome is good and which is bad. Signed-off-by: Anthony Yeh go/vt/topo/cells_aliases.go go/vt/topo/cells_aliases_test.go go/vt/vtctl/cells_aliases.go test/cell_aliases.py commit ed078eb0ab9fa9d27642db5be39084dd77fc5256 Author: AllenZMC Date: Wed Aug 14 00:21:37 2019 +0800 Update tablet.go Signed-off-by: czm go/vt/topo/tablet.go commit 361fec06349944a97c7d8886339e9d442b99efd0 Merge: 5a2a09a8d c66d22d74 Author: Sugu Sougoumarane Date: Tue Aug 13 09:29:17 2019 -0700 Merge pull request #5087 from planetscale/ds-fix-ci-after-5057 Fix failing test in CI after merging #5057 commit c66d22d74aed7371aa5336129a532355a1de227b Author: deepthi Date: Tue Aug 13 08:52:18 2019 -0700 #5048 changed how we delete from copy_state table, the testcase needs to be updated to conform to that Signed-off-by: deepthi go/vt/vttablet/tabletmanager/vreplication/vcopier_test.go commit 5a2a09a8df57a231bec592458f96446cc9fa2419 Merge: 1b8dc212d 4c288f447 Author: Sugu Sougoumarane Date: Mon Aug 12 17:52:10 2019 -0700 Merge pull request #5057 from planetscale/ds-lastpk-fix fix duplicate key error during resharding commit 1b8dc212d54e425592f38959cd8902d1dcf4dbf9 Merge: 29f02a57f a78412ac4 Author: Sugu Sougoumarane Date: Mon Aug 12 17:39:32 2019 -0700 Merge pull request #5064 from planetscale/ss-vrepl-participants migrater: resharding_journal: participants change commit 29f02a57fc8671c6932ce55ae760be3b2aba9b1d Merge: 46a9f3359 b18aadfbe Author: Sugu Sougoumarane Date: Mon Aug 12 17:39:13 2019 -0700 Merge pull request #5073 from ethan-daocloud/dev-wgm-190810 package/worker: misspelled word in html template correction commit 46a9f3359e8dc7f99ced8558d0ea95de2b912c51 Merge: b5eb51a6b acd91e8c4 Author: Sugu Sougoumarane Date: Mon Aug 12 17:38:36 2019 -0700 Merge pull request #5081 from planetscale/morgo-bootrap-pythonless Gate Python and Java dependencies commit acd91e8c4f824f5a163e76be5696ac54835b508e Author: Morgan Tocker Date: Mon Aug 12 16:07:09 2019 -0600 Add BUILD_JAVA flag too Signed-off-by: Morgan Tocker bootstrap.sh commit 132fd5dec5d6837c0bdf8345a1126c5c64a74b23 Author: Morgan Tocker Date: Mon Aug 12 15:53:00 2019 -0600 Gate Python dependencies The plan is to remove python dependencies, so this makes the first step of not requiring it for bootstrap. The goal is that a user can do this: BUILD_PYTHON=0 ./bootstrap.sh source dev.env make ./tools/unit_test_runner.sh This only runs unit tests, but in future Go-based end-to-end testing is planned. Signed-off-by: Morgan Tocker bootstrap.sh commit b5eb51a6b17f17af8b2002187fdaf653ef47cf96 Merge: 389cb88cd 806870360 Author: Deepthi Sigireddi Date: Mon Aug 12 10:35:50 2019 -0700 Merge pull request #5074 from ethan-daocloud/patch-4 cleanup: word correction in tx_serializer.go commit 389cb88cd262c299d1054ee9323a4c7f8f7127a9 Merge: 1ecdd8a9f 270484d4e Author: Deepthi Sigireddi Date: Mon Aug 12 10:35:08 2019 -0700 Merge pull request #5079 from AllenZMC/patch-1 fix wrong spells in acl.go commit 1ecdd8a9f6b8f14fb31eb73d498820a2c6cf6bf1 Author: Anthony Yeh Date: Mon Aug 12 09:52:48 2019 -0700 vtbackup: Don't enforce timeouts. (#5071) These have done more harm than good. If a backup has been going for a while, giving up and starting over from scratch is pretty much never going to help. We should just keep trying and have a system that alerts a human if it's taking longer than expected. Signed-off-by: Anthony Yeh go/cmd/vtbackup/vtbackup.go commit 270484d4eedeee014c576796c946db8d62125909 Author: AllenZMC Date: Mon Aug 12 23:12:13 2019 +0800 fix wrong spells in acl.go Signed-off-by: czm go/vt/tableacl/acl/acl.go commit b9d707fbc4351aea35e5bc8bd34c2994da3e0550 Merge: 7e99841f0 aa33b3aab Author: Jon Tirsen Date: Mon Aug 12 13:50:50 2019 +1000 Merge pull request #5054 from kalfonso/kalfonso.190801-vttestserver-alter-vschema Add ability to process vschema migrations during vttestserver startup commit 999613d6bfd09194d0d912a79e7dfbdb51d3b0b3 Merge: 9a2571b44 7e99841f0 Author: Deepthi Sigireddi Date: Sat Aug 10 19:36:24 2019 -0700 Merge branch 'master' into ds-xb-5062 commit 7e99841f01af768a09985c223d545880474a9456 Merge: 95f1642e6 11391f184 Author: Deepthi Sigireddi Date: Sat Aug 10 19:32:55 2019 -0700 Merge pull request #5065 from planetscale/xtrabackup-stream-logs xtrabackup: Better support for large datasets commit 11391f18495e28b14587e11c7f78447913da4c38 Author: Anthony Yeh Date: Sat Aug 10 14:59:13 2019 -0700 Test data striping in integration test. Signed-off-by: Anthony Yeh test/backup.py test/xtrabackup_xbstream.py commit 870a07f62651100ced1ded311796079db7170295 Author: Anthony Yeh Date: Sat Aug 10 14:58:18 2019 -0700 Add unit test for data striping. Signed-off-by: Anthony Yeh go/vt/mysqlctl/xtrabackupengine_test.go commit b1855731795294dc2645f64f34f441662bcfe53a Author: Anthony Yeh Date: Sat Aug 10 01:11:06 2019 -0700 Add data striping for xtrabackup. Signed-off-by: Anthony Yeh go/vt/mysqlctl/xtrabackupengine.go commit af1344782605bccb2ecf5401c64419179cef3c6d Author: Anthony Yeh Date: Sat Aug 10 10:12:03 2019 -0700 Add verbose flag to xbstream extraction command. Signed-off-by: Anthony Yeh go/vt/mysqlctl/xtrabackupengine.go commit 80687036039a9dc31c57062cc39c6f17c94f36f1 Author: ethan Date: Sat Aug 10 23:43:49 2019 +0800 cleanup: word correction in tx_serializer.go Signed-off-by: Guangming Wang go/vt/vttablet/tabletserver/txserializer/tx_serializer.go commit b18aadfbe6a0bb89fc513fe4d6f68c753f2938fc Author: Guangming Wang Date: Sat Aug 10 16:27:40 2019 +0800 package/worker: misspelled word in html template correction Signed-off-by: Guangming Wang go/vt/worker/split_clone_cmd.go go/vt/worker/vertical_split_clone_cmd.go commit fdce9691fda8068c600994a296719a0b0207c650 Author: Anthony Yeh Date: Fri Aug 9 23:05:24 2019 -0700 Clean up Close() error handling. Signed-off-by: Anthony Yeh go/vt/mysqlctl/builtinbackupengine.go commit 9a2571b4471dec132fb69a7312de0906578a143f Author: deepthi Date: Fri Aug 9 21:32:50 2019 -0700 check whether backup is already running Signed-off-by: deepthi go/vt/vttablet/tabletmanager/rpc_backup.go commit f0b6b964f38c23d31db0b7eb5317e6bbb36fb13c Author: deepthi Date: Fri Aug 9 21:23:38 2019 -0700 implement boolean state for xtrabackup, and stats variable for whether online backup is running Signed-off-by: deepthi go/vt/mysqlctl/backupengine.go go/vt/mysqlctl/builtinbackupengine.go go/vt/mysqlctl/xtrabackupengine.go go/vt/vttablet/tabletmanager/action_agent.go go/vt/vttablet/tabletmanager/rpc_backup.go commit 93074c50a61657992109dd6d23dbc238be5fd78f Author: Anthony Yeh Date: Fri Aug 9 15:58:45 2019 -0700 Use move-back instead of copy-back. To avoid requiring 2x disk space upon restore. Signed-off-by: Anthony Yeh go/vt/mysqlctl/xtrabackupengine.go commit 4cb274d9fe564fcd1b891edb4f934ef5c51b18b6 Author: Anthony Yeh Date: Fri Aug 9 13:09:49 2019 -0700 xtrabackup: Add verbose flag to tar. Signed-off-by: Anthony Yeh go/vt/mysqlctl/xtrabackupengine.go commit 36fef026e81cbac81241d02db6a9d09e0f9c735a Author: Anthony Yeh Date: Fri Aug 9 14:18:26 2019 -0700 Scan lines to send to logger instead of direct write. Direct write didn't use Infof() so there was no timestamp. Signed-off-by: Anthony Yeh go/vt/mysqlctl/xtrabackupengine.go commit 95f1642e66b258ccd8f8d88f7d12ee891e11978b Merge: edc2a24eb 112187e0a Author: Sugu Sougoumarane Date: Fri Aug 9 12:00:34 2019 -0700 Merge pull request #5018 from planetscale/tiglabs-prepare Add Support for Prepared Statements commit aa9808ad42104edc7020ba60402be2c20eab6760 Author: Rasika Kale Date: Fri Aug 9 10:49:45 2019 -0700 - Completed Addition expression and added appropriate tests - In the process of implenting subtraction and multiplication function (marked within comments) Signed-off-by: Rasika Kale go/sqltypes/arithmetic.go go/sqltypes/arithmetic_test.go commit 112187e0a5ac6afd0d257c225fd3fceb2b9237b6 Author: Saif Alharthi Date: Thu Aug 8 23:22:22 2019 -0700 Added end to end test fail ComPrepare and make sure other queries do not get affacted Signed-off-by: Saif Alharthi test/prepared_statement_test.py commit edc2a24ebe854d6c98a25d780e75d1f983af7c64 Author: Anthony Yeh Date: Thu Aug 8 23:04:10 2019 -0700 docker: vitess/k8s: Include all my.cnf template files. (#5068) There are now a larger set of required templates because we have auto-included files for every minor version (e.g. 5.6 vs 5.7). Just include everything instead of trying to pick and choose. Signed-off-by: Anthony Yeh docker/k8s/Dockerfile commit d90e7233732aa9da1af039173ec6d2abf5a9dc96 Author: Saif Alharthi Date: Thu Aug 8 23:02:53 2019 -0700 Address comments Signed-off-by: Saif Alharthi go/mysql/conn.go commit 58a810f82363d83289e97462f206b248ec116371 Author: Saif Alharthi Date: Thu Aug 8 22:05:45 2019 -0700 Fixed tests and bug in ComPrepare Signed-off-by: Saif Alharthi bootstrap.sh go/mysql/conn.go commit d7fb06086291c0283a670b8b0b882eb6ba4239c0 Merge: 3f67a4a4b 23c5ac32d Author: Saif Alharthi Date: Thu Aug 8 21:54:19 2019 -0700 Merge remote-tracking branch 'origin/master' into tiglabs-prepare Signed-off-by: Saif Alharthi commit b56856b301045714c0f77579dfa62636ee3a44c9 Author: Anthony Yeh Date: Thu Aug 8 16:13:24 2019 -0700 xtrabackup: Stream stderr to logs. This is needed for long-running backups so that the xtrabackup process doesn't block after the write buffer fills up. It's also nice for checking in on progress during a long upload. Signed-off-by: Anthony Yeh go/vt/mysqlctl/xtrabackupengine.go go/vt/mysqlctl/xtrabackupengine_test.go commit e663c319f6cd7cb515123659d57ec5802b49ffd7 Author: deepthi Date: Thu Aug 8 17:51:32 2019 -0700 address review comments Signed-off-by: deepthi go/vt/vttablet/tabletmanager/rpc_backup.go commit 89c4752cf14f7a22db1c372ac67dc51ddaee4b52 Author: deepthi Date: Thu Aug 8 17:32:23 2019 -0700 don't take the action lock while running xtrabackup because that prevents tablet from updating its replication lag Signed-off-by: deepthi go/vt/vttablet/tabletmanager/rpc_backup.go commit a78412ac431b090c622d8816bf0f63a4e12887ed Author: Sugu Sougoumarane Date: Tue Jul 9 16:33:02 2019 -0700 migrater: resharding_journal: participants change Make all sources as participants. It's not worth doing exact computations in this case. Signed-off-by: Sugu Sougoumarane go/vt/wrangler/migrater.go commit 23c5ac32d56ff7c98763c77d517c92da3bde34e2 Merge: 00dfc65f3 20d83134b Author: Sugu Sougoumarane Date: Thu Aug 8 15:30:26 2019 -0700 Merge pull request #5048 from planetscale/ss-vrepl-clean-copy-state vreplication: clean-up copy_state correctly commit 00dfc65f38642742af4c4fc3b406c2f0c55f76bf Author: Morgan Tocker Date: Thu Aug 8 00:41:43 2019 -0600 Add initial support for capabilities (#4987) * Add initial support for capabilities This eliminates the need to set MYSQL_FLAVOR Signed-off-by: Morgan Tocker * Removed MYSQL_FLAVOR variable precedence It will cause backwards compatibility problems, since many users set "MySQL56" for any MySQL system. Signed-off-by: Morgan Tocker * Address PR feedback (WIP) Signed-off-by: Morgan Tocker * Fixed mysql_safe to not use capabilitities Reverted small changes to configs Signed-off-by: Morgan Tocker * fix version detection Signed-off-by: Morgan Tocker * Fix style, re-add EXTRA_MY_CNF from review Signed-off-by: Morgan Tocker * Address review feedback Signed-off-by: Morgan Tocker * address remaining feedback Signed-off-by: Morgan Tocker * Remove rogue added space Signed-off-by: Morgan Tocker * Address PR feedback Signed-off-by: Morgan Tocker * Address PR feedback Signed-off-by: Morgan Tocker * Fix broken test Signed-off-by: Morgan Tocker * Fixed tests Signed-off-by: Morgan Tocker * Addressed PR feedback Added tests for version detection Signed-off-by: Morgan Tocker * update copyright Signed-off-by: Morgan Tocker * Remove unset MYSQL_FLAVOR I thought about this: it's a bad idea. It means that if there was a test that created 2 mysqld's, the usage would not be repeatable/idempotent. Signed-off-by: Morgan Tocker * Make sure error is caught. Signed-off-by: Morgan Tocker * Address PR Feedback Signed-off-by: Morgan Tocker config/mycnf/master_mariadb.cnf config/mycnf/master_mariadb100.cnf config/mycnf/master_mariadb101.cnf config/mycnf/master_mariadb102.cnf config/mycnf/master_mariadb103.cnf config/mycnf/master_mysql56.cnf config/mycnf/master_mysql57.cnf config/mycnf/master_mysql80.cnf dev.env examples/local/env.sh examples/local/vttablet-up.sh go/vt/mysqlctl/capabilityset.go go/vt/mysqlctl/mysqld.go go/vt/mysqlctl/mysqld_test.go go/vt/mysqlctl/version.go commit 5dfbae831b69619e6233eaa6aed4665fee78fdf5 Merge: 8dcbbb9ac 9b2edf52d Author: Deepthi Sigireddi Date: Wed Aug 7 11:45:05 2019 -0700 Merge pull request #5059 from planetscale/docker-xtrabackup docker: Add XtraBackup to vitess/lite. commit 8dcbbb9acd52096d71b047c471787b3c5b70200b Merge: 7664d27b1 d4d4c34ec Author: Deepthi Sigireddi Date: Wed Aug 7 11:44:36 2019 -0700 Merge pull request #5052 from planetscale/vtbackup-skip vtbackup: Only consider complete backups when looking for latest backup. commit 3f67a4a4bae52d79ad31baf129904a5bf09a8b2a Author: Saif Alharthi Date: Wed Aug 7 10:14:50 2019 -0700 Fix mount path Signed-off-by: Saif Alharthi docker/test/run.sh commit 3dc1bf5cebfef8037a61f47d853db995e4cf4a7d Merge: 0fedf7999 7664d27b1 Author: Saif Alharthi Date: Wed Aug 7 10:01:15 2019 -0700 Merge remote-tracking branch 'origin/master' into tiglabs-prepare Signed-off-by: Saif Alharthi commit 0fedf799903264632e4e037c0b1d76df75ebf495 Author: Saif Alharthi Date: Wed Aug 7 09:53:30 2019 -0700 Fix Tests Signed-off-by: Saif Alharthi docker/test/run.sh go/mysql/conn.go go/mysql/fakesqldb/server.go go/mysql/query.go go/mysql/query_test.go go/mysql/server.go go/mysql/server_test.go go/vt/vtgate/executor.go go/vt/vtgate/executor_framework_test.go go/vt/vtgate/plugin_mysql_server.go go/vt/vtgate/plugin_mysql_server_test.go go/vt/vtgate/vtgate.go go/vt/vtqueryserver/plugin_mysql_server.go go/vt/vtqueryserver/plugin_mysql_server_test.go commit aa33b3aab805d118040c5dcb8a4fd0ccb5283b2f Author: Karel Alfonso Sague Date: Thu Aug 1 18:24:59 2019 +1000 Add ability to process vschema migrations during vttestserver startup Signed-off-by: Karel Alfonso Sague go/cmd/vttestserver/data/schema/app_customer/v001__create_customer_table.sql go/cmd/vttestserver/data/schema/app_customer/v002__add_customer_vschema.sql go/cmd/vttestserver/data/schema/app_customer/vschema.json go/cmd/vttestserver/data/schema/test_keyspace/v001__create_test_table.sql go/cmd/vttestserver/data/schema/test_keyspace/v002__create_hash_vindex.sql go/cmd/vttestserver/data/schema/test_keyspace/v003__add_table_vschema.sql go/cmd/vttestserver/data/schema/test_keyspace/v004__create_test_table1.sql go/cmd/vttestserver/main.go go/cmd/vttestserver/vttestserver_test.go go/vt/vtgate/endtoend/deletetest/delete_test.go go/vt/vtgate/endtoend/main_test.go go/vt/vttest/local_cluster.go commit 9b2edf52d4567f0f19661aa3d8bd3a28d839a367 Author: Anthony Yeh Date: Tue Aug 6 20:44:56 2019 -0700 docker: Add XtraBackup to vitess/lite. This allows the xtrabackup engine to be used. The image size has increased from 700MB to 750MB. Signed-off-by: Anthony Yeh docker/lite/Dockerfile commit 0307a2e3725d0eeb2d5ed5c131ddbae8c88cdb3f Author: Rasika Kale Date: Tue Aug 6 13:17:21 2019 -0700 - Completed Addition function in arithmetic.go to match behavior similar to mySQL - Added possible tests for Addition function within arithmetic_test.go Signed-off-by: Rasika Kale go/sqltypes/arithmetic.go go/sqltypes/arithmetic_test.go commit 4c288f447e98d7bbbb30a0bc9346fed18de1ff78 Author: deepthi Date: Mon Aug 5 12:41:02 2019 -0700 fix duplicate key error during copy phase caused by incorrectly inserting during catchup phase of vreplication based resharding, add test case Signed-off-by: deepthi go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go go/vt/vttablet/tabletmanager/vreplication/vcopier_test.go commit 7664d27b153c10606c1dac479587cfd3a26d4006 Merge: 4f58828bd 5195bd6f3 Author: Sugu Sougoumarane Date: Mon Aug 5 20:20:46 2019 -0700 Merge pull request #5049 from ethan-daocloud/patch-3 cleanup: correct logging message commit 4f58828bded67981bc336d039805c9b541fbedd2 Merge: a28385520 c488ece7c Author: Sugu Sougoumarane Date: Mon Aug 5 20:20:20 2019 -0700 Merge pull request #5051 from planetscale/docker-test-cleanup test.go: Re-enable clean-up of docker test dirs. commit a28385520fdf961a7292989ceb7cf3710bcfe226 Merge: b5a641967 f914826c4 Author: Sugu Sougoumarane Date: Mon Aug 5 20:16:45 2019 -0700 Merge pull request #5053 from planetscale/jw-fix-ApplyRoutingRules-file-flag Fix ApplyRoutingRules -rules_file flag commit b5a6419679ed41e834d9ec5fda4021c87eedda29 Merge: 8d60fb808 eb9f8a0d8 Author: Sugu Sougoumarane Date: Mon Aug 5 20:15:55 2019 -0700 Merge pull request #5055 from HubSpot/binlog-event-json-testcase add a testcase to binlog_event_json_test commit 5195bd6f358171fc50655d532537259b08a8f1c8 Author: ethan Date: Mon Aug 5 21:43:53 2019 +0800 cleanup: correct logging message Signed-off-by: ethan go/vt/vttablet/tabletserver/messager/engine.go commit eb9f8a0d88984d0a351a4f980da20273e3612ef6 Author: Alex Charis Date: Mon Aug 5 20:59:02 2019 -0400 add a testcase to binlog_event_json_test Signed-off-by: Alex Charis go/mysql/binlog_event_json_test.go commit d4d4c34ec63dcc15a074648321298dcb4d020cbf Author: Anthony Yeh Date: Mon Aug 5 15:23:35 2019 -0700 vtbackup: Only consider complete backups when looking for latest backup. If the latest backup is incomplete, we should ignore it and take another one. Signed-off-by: Anthony Yeh go/cmd/vtbackup/vtbackup.go commit f914826c43058837a3c353122c96a1662abc7ff3 Author: John Watson Date: Mon Aug 5 16:30:50 2019 -0700 Fix ApplyRoutingRules -rules_file flag Signed-off-by: John Watson go/vt/vtctl/vtctl.go commit 8d60fb80870f81a2609d0dcc169ccb6c792619f1 Author: Anthony Yeh Date: Mon Aug 5 13:43:07 2019 -0700 Fix Dockerfile.mariadb103 (#5050) It seems that the base distro now includes mariadb 10.1, which means the package names conflict and it was getting stuck after installing some dependencies at 10.1 and others at 10.3. These package names seem to work to force it to use 10.3. Signed-off-by: Anthony Yeh docker/bootstrap/Dockerfile.mariadb103 commit c488ece7cf493a84bc123fcbbb21417357ed95b8 Author: Anthony Yeh Date: Mon Aug 5 12:31:32 2019 -0700 test.go: Re-enable clean-up of docker test dirs. I don't see any reason this was disabled so I assume it was checked in by accident. Signed-off-by: Anthony Yeh docker/test/run.sh commit 6daeec0012fc8163857ef91fb49e0513dabc6508 Author: Anthony Yeh Date: Mon Aug 5 12:01:46 2019 -0700 Update vendored GCS client version (#5047) * Update GCS client version. Signed-off-by: Anthony Yeh * restore: Add more detail to errors during file copy. Signed-off-by: Anthony Yeh go/vt/mysqlctl/builtinbackupengine.go vendor/vendor.json commit 20d83134bfe8d4724c3ed3562bc4f73ce32c6d94 Author: Sugu Sougoumarane Date: Sun Aug 4 19:37:34 2019 -0700 vreplication: ignore table not found error Legacy mode vreplication will not create copy_state. So, we have to ignore the table not found error when deleting from copy_state. Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/engine.go commit 96138755a91bb8185d0bfc6f10b231baeacf7654 Author: Sugu Sougoumarane Date: Sun Jul 21 11:37:30 2019 -0700 vreplication: clean-up copy_state correctly * On delete of a row in _vt.vreplication, we should also cleanup the copy_state table, because it may have related rows. * Made workflow into a flag, but mandatory. Otherwise the number of unnamed arguments are too many and command becomes unreadable. * Added ability to read from _vt.copy_state using VReplicaionExec. Signed-off-by: Sugu Sougoumarane go/vt/vtctl/vtctl.go go/vt/vttablet/tabletmanager/vreplication/controller_plan.go go/vt/vttablet/tabletmanager/vreplication/controller_plan_test.go go/vt/vttablet/tabletmanager/vreplication/engine.go go/vt/vttablet/tabletmanager/vreplication/engine_test.go go/vt/vttablet/tabletmanager/vreplication/framework_test.go go/vt/vttablet/tabletmanager/vreplication/vcopier_test.go go/vt/vttablet/tabletmanager/vreplication/vplayer_test.go go/vt/vttablet/tabletmanager/vreplication/vreplicator.go go/vt/wrangler/testlib/migrate_served_from_test.go go/vt/wrangler/testlib/migrate_served_types_test.go commit 9682ee0b76fd828cbf3ed93f2a3332370b70b1aa Merge: aace05164 dfda28482 Author: Sugu Sougoumarane Date: Sun Aug 4 15:42:19 2019 -0700 Merge pull request #4981 from planetscale/ss-migrater VReplication based traffic migrater commit dfda28482f67658ce3cb4e3f7efaf6bcbb3b4792 Author: Sugu Sougoumarane Date: Sun Aug 4 12:54:31 2019 -0700 migrater: adddress more review comments Signed-off-by: Sugu Sougoumarane go/vt/vtctl/vtctl.go go/vt/wrangler/migrater.go commit 4b86104476d32861f93c94077da5cf26627b3628 Author: Sugu Sougoumarane Date: Fri Jul 19 19:32:34 2019 -0700 migrater: address review comments Signed-off-by: Sugu Sougoumarane go/vt/vtctl/vtctl.go go/vt/vttablet/tabletmanager/vreplication/engine.go go/vt/wrangler/fake_tablet_test.go go/vt/wrangler/migrater.go go/vt/wrangler/migrater_test.go commit 3b44876002f5c3cfd20f879994388ce643120b89 Author: Sugu Sougoumarane Date: Mon Jul 8 20:33:23 2019 -0700 migrater: expose separate vtctl commands Signed-off-by: Sugu Sougoumarane go/vt/vtctl/vtctl.go go/vt/wrangler/migrater.go go/vt/wrangler/migrater_test.go commit 0257cc06f74be69c664cddcc801bbe3c43412488 Author: Sugu Sougoumarane Date: Mon Jul 8 19:01:52 2019 -0700 migrater: auto-detect migration type Signed-off-by: Sugu Sougoumarane go/vt/wrangler/migrater.go go/vt/wrangler/migrater_test.go commit 40ef5ff329cfbf12f0336fe405f194969ff2573c Author: Sugu Sougoumarane Date: Mon Jul 8 16:28:34 2019 -0700 migrater: use workflow as input Specifying shards and uids wasn't user-friendly. Specifying workflow names should better. However, it will be the user's responsibilty to keep them unique. Signed-off-by: Sugu Sougoumarane go/vt/wrangler/migrater.go go/vt/wrangler/migrater_env_test.go go/vt/wrangler/migrater_test.go commit 1a88365c77dceab13066b9d23f40d8d28683f1d1 Author: Sugu Sougoumarane Date: Mon Jul 8 12:18:33 2019 -0700 migrater: simplify parameters Since we don't support multiple source or target keyspaces, the uid parameters can be simplified to only have shards as keys, and there will be a separate targetKeyspace parameter that applies to all shards. Signed-off-by: Sugu Sougoumarane go/vt/wrangler/migrater.go go/vt/wrangler/migrater_env_test.go go/vt/wrangler/migrater_test.go commit 61af9f7dc574a3f1341ccb388b64309fc1da35fb Author: Sugu Sougoumarane Date: Sun Jul 7 22:12:43 2019 -0700 migrater: add logs and comments Signed-off-by: Sugu Sougoumarane go/vt/wrangler/migrater.go commit 19f23cc041c2e823a7b9c6fc15d3c222a466f3a6 Author: Sugu Sougoumarane Date: Sun Jul 7 21:23:35 2019 -0700 migrater: add more fields to Journal Signed-off-by: Sugu Sougoumarane go/vt/proto/binlogdata/binlogdata.pb.go go/vt/wrangler/migrater.go go/vt/wrangler/migrater_test.go proto/binlogdata.proto py/vtproto/binlogdata_pb2.py commit da43f739cc17ec15642862e1a3d89a04e3c9fb14 Author: Sugu Sougoumarane Date: Sun Jul 7 20:29:26 2019 -0700 migrater: make table routing rules symmetrical Signed-off-by: Sugu Sougoumarane go/vt/wrangler/migrater.go go/vt/wrangler/migrater_test.go commit e359f3e05887a289165a71be3c6f43714e184178 Author: Sugu Sougoumarane Date: Sun Jul 7 20:10:41 2019 -0700 migrater: unit tests done Signed-off-by: Sugu Sougoumarane go/vt/wrangler/migrater.go go/vt/wrangler/migrater_env_test.go go/vt/wrangler/migrater_test.go commit 12d92d83904ee48294c7f3f1ed5c1decbc6ca0e3 Author: Sugu Sougoumarane Date: Sun Jul 7 14:10:26 2019 -0700 migrater: refactor tests, and add more Signed-off-by: Sugu Sougoumarane go/vt/wrangler/fake_tablet_test.go go/vt/wrangler/migater_env_test.go go/vt/wrangler/migrater_test.go commit 0614231fac3292e04918a66bfa6fc74f22f254b6 Author: Sugu Sougoumarane Date: Sun Jul 7 12:44:42 2019 -0700 migrater: more tests and cleanup Signed-off-by: Sugu Sougoumarane go/vt/wrangler/fake_dbclient_test.go go/vt/wrangler/migrater.go go/vt/wrangler/migrater_test.go commit fa295dec75e847a9eb293d6d41ef8b4c83e7cf94 Author: Sugu Sougoumarane Date: Sat Jul 6 20:31:12 2019 -0700 migrater: more tests Signed-off-by: Sugu Sougoumarane go/vt/wrangler/migrater.go go/vt/wrangler/migrater_test.go commit 82cfaf115fee83385f271bd3e81b02a41004d6e9 Author: Sugu Sougoumarane Date: Sat Jul 6 09:15:23 2019 -0700 migrater: quick cleanup Signed-off-by: Sugu Sougoumarane go/vt/binlog/binlogplayer/mock_dbclient.go go/vt/wrangler/fake_dbclient_test.go go/vt/wrangler/migrater.go go/vt/wrangler/migrater_test.go commit bcf5787d7738c9a9d304a3dabe7d66ac1856dc4b Author: Sugu Sougoumarane Date: Sat Jul 6 01:38:19 2019 -0700 migrater: test framework and initial test Signed-off-by: Sugu Sougoumarane go/vt/binlog/binlogplayer/mock_dbclient.go go/vt/wrangler/fake_dbclient.go go/vt/wrangler/fake_tablet_test.go go/vt/wrangler/migrate.go go/vt/wrangler/migrate_test.go commit f1d09580332eef8c04bfb5e3e45a12c0fd967acf Author: Sugu Sougoumarane Date: Fri Jul 5 13:00:23 2019 -0700 migrater: migrate reads and validate Signed-off-by: Sugu Sougoumarane go/vt/wrangler/migrate.go commit 3fb294471c991d8e44c44b0c538a9f9bedc1e0f9 Author: Sugu Sougoumarane Date: Tue Jul 2 10:30:40 2019 -0700 migrater: initial cut Signed-off-by: Sugu Sougoumarane go/vt/proto/binlogdata/binlogdata.pb.go go/vt/vttablet/tabletmanager/vreplication/controller_plan.go go/vt/vttablet/tabletmanager/vreplication/controller_plan_test.go go/vt/vttablet/tabletmanager/vreplication/engine.go go/vt/vttablet/tabletmanager/vreplication/engine_test.go go/vt/wrangler/migrate_writes.go proto/binlogdata.proto py/vtproto/binlogdata_pb2.py commit aace0516447981e2101ec724dcbe39bccf8efccc Merge: 387685c66 c936f1a9d Author: Sugu Sougoumarane Date: Sat Aug 3 18:53:18 2019 -0700 Merge pull request #5039 from planetscale/ds-bl-event-json-doc JSON String length computation: docs and unit tests commit 387685c6634f31345704579d78263f7e76baefd1 Merge: af954f0dd 44e4439e9 Author: Sugu Sougoumarane Date: Sat Aug 3 18:52:24 2019 -0700 Merge pull request #5040 from HubSpot/vstream-for-vtgate-java Java Client: add VStream method to the `VTGateConnection` commit af954f0dd66781fa988cfd40d7e56cead56ec75f Merge: 61621b7d8 1d4652db2 Author: Sugu Sougoumarane Date: Sat Aug 3 18:51:54 2019 -0700 Merge pull request #5042 from kalfonso/kalfonso.190730-vttestserver-localhost Allow start local cluster using a provided tablet host name commit a138a405df9d8d534ac44c3bececd7093245b3cd Merge: 03217bd2f f93c96c73 Author: Saif Alharthi Date: Wed Jul 31 21:26:53 2019 -0700 Merge remote-tracking branch 'origin/master' into tiglabs-prepare Signed-off-by: Saif Alharthi commit 03217bd2f263585842ac24b351427f8e3c3946bf Author: Saif Alharthi Date: Wed Jul 31 19:01:44 2019 -0700 Document test Signed-off-by: Saif Alharthi test/prepared_statement_test.py commit 61621b7d8502170e86656384ed56fbe72b09907f Merge: f93c96c73 bfeed1ead Author: Deepthi Sigireddi Date: Wed Jul 31 17:04:58 2019 -0700 Merge pull request #5044 from planetscale/morgo-remove-docs Remove docs now hosted in vitessio/website commit bfeed1ead9d5e524ec086d9ff3e4034e11d5fb2e Author: Morgan Tocker Date: Wed Jul 31 10:25:29 2019 -0700 Remove docs now hosted in vitessio/website This removes the docs and images known to be in the website repo. Design documents are left untouched. Signed-off-by: Morgan Tocker doc/AdvancedFeaturesIndex.md doc/BackupAndRestore.md doc/CodeReviews.md doc/Concepts.md doc/Contributing.md doc/FAQ.md doc/GettingStarted.md doc/GettingStartedKubernetes.md doc/GitHubWorkflow.md doc/HorizontalReshardingGuide.md doc/HorizontalReshardingWorkflowGuide.md doc/Messaging.md doc/Monitoring.md doc/MySQLServerProtocol.md doc/Production.md doc/ProductionPlanning.md doc/ReferenceTables.md doc/Reparenting.md doc/RowBasedReplication.md doc/ScalabilityPhilosophy.md doc/ScalingMySQL.md doc/SchemaManagement.md doc/SchemaSwap.md doc/ServerConfiguration.md doc/Sharding.md doc/ShardingKubernetes.md doc/ShardingKubernetesWorkflow.md doc/TestingOnARamDisk.md doc/TopologyService.md doc/Troubleshooting.md doc/TwoPhaseCommitGuide.md doc/UpdateStream.md doc/Upgrading.md doc/UserGuideIntroduction.md doc/VSchema.md doc/VTTabletModes.md doc/VTTabletModules.png doc/VitessApi.md doc/VitessComponents.png doc/VitessOverview.md doc/VitessOverview.png doc/VitessReplication.md doc/VitessSequences.md doc/VitessTransportSecurityModel.md doc/VtExplain.md doc/internal/PublishWebsite.md doc/slides/Percona2015.pptx doc/slides/Vitess2014.pdf doc/vtctlReference.md commit 1d4652db29858cdec7eabe75ef4f26e00bf5cab2 Author: Karel Alfonso Sague Date: Tue Jul 30 17:32:40 2019 +1000 Allow start local cluster using a provided tablet host name This helps fix a name resolution problem when initializing the tablet. If flag "tablet_hostname" is not provided it will be derived from the OS' hostname. The way it is implemented there is not guarantee that ```net.LookupHost(os.HostName())``` will return a valid IP for certain local env dns configs, i.e, in Mac OS X, hostname can be configured using the system's resolver which is not used by ```net.LookupHost``` Reference: init_tablet.go:151 Signed-off-by: Karel Alfonso Sague go/cmd/vttestserver/main.go go/vt/vttest/local_cluster.go go/vt/vttest/vtprocess.go commit c7bd871ffa63e063de6310d5eecaef7da324cec2 Author: Rasika Kale Date: Tue Jul 30 15:54:36 2019 -0700 Fixed Test Results in arithmetic_test.go to output correctly Signed-off-by: Rasika Kale go/sqltypes/arithmetic.go go/sqltypes/arithmetic_test.go commit 44e4439e92d1d83da315173bd3edddd50148d43b Author: Paul Hemberger Date: Tue Jul 30 17:36:51 2019 -0400 add the vstream method to the VTGateConnection as well Signed-off-by: Paul Hemberger java/client/src/main/java/io/vitess/client/VTGateConnection.java commit c936f1a9dcbac8f1539933ba27aa1824cf4a7f61 Author: deepthi Date: Tue Jul 30 12:34:09 2019 -0700 add unit tests for 1-byte, 2-byte and 3-byte json string lengths Signed-off-by: deepthi go/mysql/binlog_event_json_test.go commit 017cf57f8879ddf75ae0f5ed38c1c377e02d037a Author: Saif Alharthi Date: Tue Jul 30 12:21:18 2019 -0700 Quick fix Signed-off-by: Saif Alharthi go/mysql/conn.go go/mysql/query.go go/vt/vtgate/plugin_mysql_server.go commit 5eb5830783ee7b8a372727a471336553b805bb92 Author: Saif Alharthi Date: Tue Jul 30 11:24:02 2019 -0700 Addressed partial comments Signed-off-by: Saif Alharthi go/mysql/conn.go go/mysql/query.go go/mysql/query_test.go go/vt/vtgate/executor.go go/vt/vtgate/plugin_mysql_server.go go/vt/vtgate/vtgate.go commit ca871d3443473da6cfb048bd0be6b259c31ce1a3 Author: deepthi Date: Tue Jul 30 08:48:18 2019 -0700 also add a link to mysql server 8.0 implementation Signed-off-by: deepthi go/mysql/binlog_event_json.go commit fed4d0e034dcdb4cbf503178b771e8d75e1c9d8b Author: deepthi Date: Tue Jul 30 08:41:20 2019 -0700 change function name to be more descriptive, add link to mysql source and comments Signed-off-by: deepthi go/mysql/binlog_event_json.go commit fd3caf2ceeada87fd8ba008b2e14a1d789cef42c Author: Rasika Kale Date: Mon Jul 29 15:26:05 2019 -0700 Adjusted castFromNunmeric() to return only Value instead of Value and error Changed tests TestAdd and TestCastFromNumeric_in arithmetic_test.go to return value output instead of error Signed-off-by: Rasika Kale go/sqltypes/arithmetic.go go/sqltypes/arithmetic_test.go commit 04c110073830a2c7dfbf52691f703bda4d2dd3c6 Author: Saif Alharthi Date: Wed Jul 24 14:07:49 2019 -0700 Edit utils.py Signed-off-by: Saif Alharthi test/utils.py commit 786f7d8f2d08ad0ff36d426e4f12ad0e5a37f81a Author: Saif Alharthi Date: Wed Jul 24 12:56:34 2019 -0700 Fix TestTypeError Signed-off-by: Saif Alharthi go/sqltypes/type_test.go commit 611820a54844f95d1818c8c7d5325e00a8d7ba07 Author: Saif Alharthi Date: Wed Jul 24 11:55:15 2019 -0700 Set correct value for topo-server Signed-off-by: Saif Alharthi test/utils.py commit 6a01fe09aa9b91a54cf0c780704e469c9d1ed3eb Author: Saif Alharthi Date: Wed Jul 24 11:53:40 2019 -0700 Replaced etcd2 with zk for end to end tests Signed-off-by: Saif Alharthi go/mysql/query_test.go test/utils.py commit 85a4f18552ba03538771073a68f5e28a6c7ec3c8 Author: Saif Alharthi Date: Wed Jul 24 09:43:53 2019 -0700 Updated TestComPrepare test Signed-off-by: Saif Alharthi go/mysql/query_test.go go/mysql/server_test.go go/vt/vtgate/executor_dml_test.go commit c55be518ec2637dd7344283e726087dcd63d020f Author: Saif Alharthi Date: Tue Jul 23 15:50:46 2019 -0700 Added dependency to bootstrap.sh and edited python test Signed-off-by: Saif Alharthi bootstrap.sh go/mysql/query_test.go test/prepared_statement_test.py vagrant-scripts/bootstrap_vm.sh commit ed69725078d4d36ef1cc7eeb39440e8d01a905e8 Author: Saif Alharthi Date: Tue Jul 23 12:06:59 2019 -0700 Added mysql-connector dependency Signed-off-by: Saif Alharthi go/mysql/server_test.go vagrant-scripts/bootstrap_vm.sh commit 387cb98cd7222ceb9706890cda5d8a0e40ba88ab Merge: a51fabcb7 69729e981 Author: Saif Alharthi Date: Mon Jul 22 15:25:51 2019 -0700 Merge branch 'tiglabs-prepare' of github.com:planetscale/vitess into tiglabs-prepare Signed-off-by: Saif Alharthi commit a51fabcb782968fd4800168f61a72148cce564b3 Author: Saif Alharthi Date: Mon Jul 22 14:45:46 2019 -0700 Added Executor test for select Signed-off-by: Saif Alharthi go/vt/vtgate/executor_select_test.go commit 69729e981bd55e29ba80e82b74228af6383dab07 Author: Saif Alharthi Date: Mon Jul 22 14:45:46 2019 -0700 Added Excutor test for select Signed-off-by: Saif Alharthi go/vt/vtgate/executor_select_test.go commit d278419fd72644a61466bcd72db99ae1ce732e94 Author: Saif Alharthi Date: Mon Jul 22 14:34:23 2019 -0700 Add Executor test for DML Signed-off-by: Saif Alharthi go/vt/vtgate/executor_dml_test.go commit b72f38b6682269682144536108da1a397d3303ea Merge: bc1ac07b7 fd262fe98 Author: Saif Alharthi Date: Mon Jul 22 13:18:52 2019 -0700 Merge remote-tracking branch 'origin/master' into tiglabs-prepare Signed-off-by: Saif Alharthi commit bc1ac07b77a4dda37bc21f0dfadb0ce235e00a1b Author: Saif Alharthi Date: Mon Jul 22 11:53:37 2019 -0700 Added test for TestComStmtExecute Signed-off-by: Saif Alharthi go/mysql/query.go go/mysql/query_test.go commit 0d396074b4e6bdce491ef8b4772a52505ee5942a Author: Saif Alharthi Date: Fri Jul 19 17:48:01 2019 -0700 Fix error message Signed-off-by: Saif Alharthi test/prepared_statement_test.py commit 698243b3d0d46b52cdf406bf092d61b242df834b Author: Saif Alharthi Date: Fri Jul 19 17:29:11 2019 -0700 Added python end to end test Signed-off-by: Saif Alharthi go/mysql/query.go go/mysql/query_test.go go/sqltypes/type.go test/config.json test/prepared_statement_test.py commit 1470f76320744c13e237454a1b98113b117fb4a8 Author: Saif Alharthi Date: Wed Jul 17 15:27:16 2019 -0700 Added executor tests. They are faulty now. Signed-off-by: Saif Alharthi go/vt/vtgate/executor_dml_test.go go/vt/vtgate/executor_framework_test.go go/vt/vtgate/executor_select_test.go go/vt/vtgate/executor_test.go test/utils.py commit 70096dd341104430a86c8d8ec7e2c60e618d0522 Merge: 96ed06863 dceeeba06 Author: Saif Alharthi Date: Tue Jul 16 08:35:35 2019 -0700 Merge remote-tracking branch 'origin/master' into tiglabs-prepare Signed-off-by: Saif Alharthi commit 96ed068636604534ccef572a3d94c2df252d9a77 Author: Saif Alharthi Date: Mon Jul 15 15:29:28 2019 -0700 added few more tests in query_test Signed-off-by: Saif Alharthi go/mysql/query_test.go go/mysql/server_test.go commit 8d641ee0fb01084a959d27704abf8359d6fa6fed Author: Saif Alharthi Date: Mon Jul 15 10:23:56 2019 -0700 Added test for ComPrepare Signed-off-by: Saif Alharthi go/mysql/query.go go/mysql/query_test.go commit e5236777cae14a658d5030f7568ca8db7f9ed920 Merge: 9ceb1f4d3 c341ec1d5 Author: Saif Alharthi Date: Wed Jul 10 08:14:06 2019 -0700 Merge remote-tracking branch 'origin/master' into tiglabs-prepare Signed-off-by: Saif Alharthi commit 9ceb1f4d33729f22138192818bc160b090bce3e4 Merge: 24ea99faf 22c64df20 Author: Saif Alharthi Date: Sun Jun 30 15:45:43 2019 -0700 Merge remote-tracking branch 'origin/master' into tiglabs-prepare Signed-off-by: Saif Alharthi commit 24ea99faf00586d1b1f658a6d30aac87884ab348 Merge: 82c5e90ac 8e2f781e1 Author: Saif Alharthi Date: Fri Jun 28 14:51:50 2019 -0700 Merge remote-tracking branch 'origin/master' into tiglabs-prepare Signed-off-by: Saif Alharthi commit 4128986b86fde0898ea6b55729ccf81bbb18d360 Author: Toliver Jue Date: Tue Jun 18 09:00:00 2019 +0700 vtclient: Add sequential id generation and throttling Signed-off-by: Toliver Jue go/cmd/vtclient/vtclient.go commit 82c5e90ac88f4be10f61817878ade26d2800573e Author: deepthi Date: Mon Jun 17 13:26:26 2019 -0700 fix compile errors after merge Signed-off-by: deepthi go/vt/vtgate/executor.go commit ed0079038b53f273af60680494365eca2a0f3e9a Merge: 640588c28 2393ff768 Author: deepthi Date: Mon Jun 17 09:54:53 2019 -0700 Merge branch 'prepare' of git://github.com/tiglabs/vitess into tiglabs-prepare Signed-off-by: deepthi commit 2393ff76877d5b898ded79eeb6fd62e26128aacc Merge: 24d0dd027 8d0c1a9ad Author: dcadevil Date: Mon Apr 1 16:03:46 2019 +0800 Merge branch 'master' into prepare commit 2d9254351236bee70ea057aef2b33351a011a9bb Author: Sugu Sougoumarane Date: Sun Feb 24 13:50:04 2019 -0800 v3: support overlapping multi-column vindexes Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/insert.go go/vt/vtgate/planbuilder/testdata/dml_cases.txt go/vt/vtgate/planbuilder/testdata/schema_test.json commit 33188c7d8fa4da9f724866282fb14bbbc2733b41 Author: Michael Demmer Date: Sat Nov 24 17:38:33 2018 -0500 remove unneeded vitess-specific keywords used for show statements Since the vtgate executor accepts arbitrary sql identifiers as the type value for `show` statements, remove vitess-specific keywords from the grammar for things like `vitess_keyspaces`, `vitess_shards`, and more. Along the way, add support for `show keyspaces` and make sure to lowercase the show target. Signed-off-by: Michael Demmer go/vt/sqlparser/sql.go go/vt/sqlparser/sql.y go/vt/sqlparser/token.go go/vt/vtgate/executor.go go/vt/vtgate/executor_test.go commit 24d0dd0272e907d090b7417d0d50ebe2ca839994 Author: dcadevil Date: Thu Jan 17 14:58:20 2019 +0800 add comments Signed-off-by: dcadevil go/mysql/conn.go commit 9f0e7c3644c87ecec40aac9ba82ec06f8ca70469 Author: dcadevil Date: Wed Jan 16 15:52:34 2019 +0800 add missing function implementation Signed-off-by: dcadevil go/vt/vtgate/plugin_mysql_server_test.go commit 25d16434e45ca08898dfc58792f4d941a7b3d271 Author: dcadevil Date: Wed Jan 16 15:22:00 2019 +0800 add missing function implementation Signed-off-by: dcadevil go/vt/vtgate/plugin_mysql_server_test.go commit 602456683c564e96c95aca51bcd557cc0a9cda24 Author: dcadevil Date: Wed Jan 16 14:31:09 2019 +0800 delete unused code Signed-off-by: dcadevil go/vt/vtgate/plugin_mysql_server.go commit 85f6d74ecb50baaaf53a7118728a1405a59529a3 Author: dcadevil Date: Wed Jan 16 14:00:45 2019 +0800 add missing function implementation Signed-off-by: dcadevil go/mysql/server_test.go go/vt/vtqueryserver/plugin_mysql_server_test.go commit 91f73b10669af120509030d27b6c728344008cea Author: dcadevil Date: Wed Jan 16 11:29:36 2019 +0800 support for the MySQL prepare command protocol Signed-off-by: dcadevil go/mysql/conn.go go/mysql/fakesqldb/server.go go/mysql/query.go go/mysql/server.go go/vt/vtgate/plugin_mysql_server.go go/vt/vtqueryserver/plugin_mysql_server.go commit 30cda05138a521f0ac3bf730d9b27bb9ca6ada06 Author: dcadevil Date: Tue Jan 15 18:49:03 2019 +0800 support for the ComPrepare Signed-off-by: dcadevil go/mysql/conn.go go/mysql/constants.go go/mysql/fakesqldb/server.go go/mysql/query.go go/mysql/server.go go/vt/vtgate/executor.go go/vt/vtgate/plugin_mysql_server.go go/vt/vtgate/vtgate.go go/vt/vtqueryserver/plugin_mysql_server.go