This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Port ERS bug fixes into 8.0 #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earcher Extract the `maxReplPosSearch` struct out to `topotools`
Add `ErrorGroup` to package concurrency, use in `waitOnNMinusOneTablets`
[vtctld / wrangler] Extract some reparent methods out to functions for shared use between wrangler and VtctldServer Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
[vtctld/wrangler] Extract `EmergencyReparentShard` logic to dedicated struct and add unit tests Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
[reparentutil / ERS] confirm at least one replica succeeded to `SetMaster`, or fail Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick a path to victory. This pulls in the changes necessary to address this comment from the 8.0 release branch.
It included picking the following:
maxReplPosSearchstruct out totopotoolsvitessio/vitess#7420ErrorGroupto package concurrency, use inwaitOnNMinusOneTabletsvitessio/vitess#7429EmergencyReparentShardlogic to dedicated struct and add unit tests vitessio/vitess#7464SetMaster, or fail vitessio/vitess#7486The major changes as part of the cherry-pick are that i deleted several test files which should be fine?