Support user data with USINGZ #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msvbg
commented
Aug 28, 2024
Cargo.toml
Outdated
| @@ -31,3 +32,6 @@ serde_json = "1" | |||
| # docs.rs uses a nightly compiler, so by instructing it to use our `doc-images` feature we | |||
| # ensure that it will render any images that we may have in inner attribute documentation. | |||
| features = ["doc-images"] | |||
|
|
|||
| [patch.crates-io] | |||
| clipper2c-sys = { rev = "210878394637f94bcd3a476bdf24ddf4ba8a39fd", git = "https://github.com/tirithen/clipper2c-sys" } | |||
There was a problem hiding this comment.
Note: fix this before merging
msvbg
force-pushed
the
usingz
branch
3 times, most recently
from
1d9fa1f
to
72d7dc3
Compare
|
One problem with this PR is that it breaks e.g. |
I think using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR to tirithen/clipper2c-sys#6. Adds a
usingzcargo feature to support user data in points.I think the main complication is the double
Boxdance to be able to pass Rust closures as a C callback. I think this is a nicer API than just a function pointer, which would also leak clipper2c-sys internal types.