Adds option to use chrome on Linux when running with WSL #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm closing this because I think that this is unecessary. We should detected that it is running on WSL2 and use Chrome on Linux, as explained here: #192 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #192, after v4.4.2 it is impossible to use Chrome on Linux when running in WSL as the system is detected as WSL and tries to always use the Chrome on Windows.
I don't know if this is the best solution to this, but i'd like to have the option to run Chrome on Linux and this solves my issue.
I'm not sure about the name of the env var and if this is clear enough, I'll be happy to accept suggestions.