Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jasmine Mocha Support #927

Closed
victor-shelepen opened this issue Mar 8, 2019 · 3 comments
Closed

Jasmine Mocha Support #927

victor-shelepen opened this issue Mar 8, 2019 · 3 comments

Comments

@victor-shelepen
Copy link

Convert tests to a more standard way. It is very hard to add new features to for external developers. Your library provides enough functionality. But it is not so well maintainable.

@shadowspawn
Copy link
Collaborator

Thanks for the feedback. I was actually doing some research on this just yesterday, and can refer you to #649

@shadowspawn
Copy link
Collaborator

shadowspawn commented Apr 27, 2019

@mojavelinux converted a couple of the test files to ava in #755 to show what it looks like, which I thought was a useful way of seeing real code for a modest time investment. If someone is interested in showing what it would look like using mocha, you could do a draft Pull Request with the same two files and a mocha setup.

Edit: @CheshireSwift has done some work in https://github.com/CheshireSwift/commander.js/tree/649-test-refactor

@shadowspawn
Copy link
Collaborator

Closing this in favour of #649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants