Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Command typings #1758

Closed
wants to merge 21 commits into from
Closed

Improve Command typings #1758

wants to merge 21 commits into from

Commits on Jun 21, 2022

  1. Add generic Command type

    @PaperStrike
    PaperStrike committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    c8629b8 View commit details
    Browse the repository at this point in the history

  2. Fix string argument type helpers

    @PaperStrike
    PaperStrike committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    7fcf574 View commit details
    Browse the repository at this point in the history

  3. Support Command.arguments type parsing

    @PaperStrike
    PaperStrike committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    9837001 View commit details
    Browse the repository at this point in the history

  4. Add StringUntypedOption type helper

    @PaperStrike
    PaperStrike committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    d9c62bb View commit details
    Browse the repository at this point in the history

  5. Simplify string argument type helpers 

    * Use multi-argument resolution for .arguments() only
* Fix a bug that untyped arguments could be parsed as possibly undefined values even if they had non-undefined default values
    @PaperStrike
    PaperStrike committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    92e5e9f View commit details
    Browse the repository at this point in the history

  6. Remove type helper default type requirements 

    These are already being checked in the overloads.
    @PaperStrike
    PaperStrike committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    6f26198 View commit details
    Browse the repository at this point in the history

  7. Properly detect possibly undefined default type

    @PaperStrike
    PaperStrike committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    606d438 View commit details
    Browse the repository at this point in the history

  8. Remove "default type" arg of StringArguments 

    as it is always `undefined`
    @PaperStrike
    PaperStrike committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    b79504e View commit details
    Browse the repository at this point in the history

  9. Clean unused vars

    @PaperStrike
    PaperStrike committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    bcbe369 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Parse unspaced ",", ending spaces, in option flags

    @PaperStrike
    PaperStrike committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    f49deec View commit details
    Browse the repository at this point in the history

  2. Add Argument and Option generic type 

    Also fixes a bug in Option class that required properties with the value undefined were typed as optional properties
    @PaperStrike
    PaperStrike committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    3e1a608 View commit details
    Browse the repository at this point in the history

  3. Type required, optional, variadic, mandatory

    @PaperStrike
    PaperStrike committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    6bfe45d View commit details
    Browse the repository at this point in the history

  4. Merge options to a single object

    @PaperStrike
    PaperStrike committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    806422f View commit details
    Browse the repository at this point in the history

  5. Type .opts return default to Options

    @PaperStrike
    PaperStrike committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    eac7d1e View commit details
    Browse the repository at this point in the history

  6. Allow .action callback type argument override 

    This is mainly for commands whose arguments and options can't be fully inferred like the global `program`
    @PaperStrike
    PaperStrike committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    a47e0ef View commit details
    Browse the repository at this point in the history

  7. Type .command arguments

    @PaperStrike
    PaperStrike committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    364e04e View commit details
    Browse the repository at this point in the history

  8. Type .command call that has no argument string

    @PaperStrike
    PaperStrike committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    5502907 View commit details
    Browse the repository at this point in the history

  9. Fix .command call related to .createCommand 

    Infer arguments only if `this['createCommand']` is not altered.
    @PaperStrike
    PaperStrike committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    9936b2d View commit details
    Browse the repository at this point in the history

  10. Allow no brackets around argument name and default to required option

    @PaperStrike
    PaperStrike committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    1d137cc View commit details
    Browse the repository at this point in the history

  11. Fix types of any Option / any Argument

    @PaperStrike
    PaperStrike committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    cb2cda2 View commit details
    Browse the repository at this point in the history

  12. Make type test pass

    @PaperStrike
    PaperStrike committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    d4b3acd View commit details
    Browse the repository at this point in the history