Make component compatible with styled-components providing the className for parent element #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: cleanup and dependencies upgrade * chore: add commitlint and lint-staged * ci(release): add semantic release workflow * chore(lint): add prettier * chore(deps): upgraded dependencies * feat(tests): migrate tests suite to jest * chore(typescript): add youtube player types * chore(tests): add tests github action workflow * ci(release): add pre-release channel * ci(tests): fix test on ci * fix(config): fix some typos * chore(commits): add commitizen cli * ci(commits): add commitlint to pull requests * chore(git): remove .vscode folder * chore(deps): upgraded dependencies
|
@karolisgrinkevicius we have updated the codebase and this code is now outdated. |
karolisgrinkevicius
force-pushed
the
master
branch
from
0f5d1a3
to
0f37fb4
Compare
|
@ruisaraiva19 I have rebased and fixed all the conflicts. Please take a look. Thanks. |
karolisgrinkevicius
force-pushed
the
master
branch
3 times, most recently
from
9278de2
to
bbf26aa
Compare
|
@karolisgrinkevicius-home24 we are using the |
karolisgrinkevicius
force-pushed
the
master
branch
from
bbf26aa
to
6ad8567
Compare
|
@ruisaraiva19 thanks for the info, I have created another PR against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make component compatible with emotion and styled-components providing the className for parent element.
Motivation
Previously this component wasn't compatible neither with emotion css in js nor styled-components due to the class name being set for child element.