-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log files grow without limit when loggingEnabled is turned off #168
Comments
I would like to use this bug as an opportunity to simplify and reconcile the logging story in iisnode. Currently there are two logging mechanisms we support: the one driven by loggingEnabled, and the one using the interceptor approach and nodeProcessCommandLine extensibility point. After this fix, only the latter will remain, but it will be wired up by default. Here is the proposal:
So where does this design leave us? By default, logs will be stored in the "iisnode" directory next to the entry point of the application. If the application is accessible at http://foo.com/server.js, logs would be accessible at http://foo.com/iisnode. In hosting environments like Azure, the default configuration will change to specify something like logDirectory=....\LogFiles\iisnode. |
I think unifying to one logging system makes sense, and the node logging system gives maximum flexibility. The only ask I would have is that all configuration settings that control logs are surfaced as simple settings in iisnode.yml (and web.config). [maxToatalLogFileSizeInKB, maxLogFileSize, logDirectory, etc.] |
Whatever we do with configuration settings there will be parity between web.config and iisnode.yml. And yes, all the settings mentioned above will be actual configuration settings (as opposed to env variables). |
So to summarize the breaking changes, we're removing some knobs and changing the default location where logs go if they turn on loggingEnabled, correct? |
Yes, the default location of logs will change. Now, iisnode still has loggingEnabled==true by default as of v0.1.19. From: Yavor Georgiev [reply@reply.github.com] So to summarize the breaking changes, we're removing some knobs and changing the default location where logs go if they turn on loggingEnabled, correct? Reply to this email directly or view it on GitHub: |
Few changes to the design outlined previously were made inline (changes in bold) |
In case of exceptions on initialization the exception is logged twice - it should be once. |
The latter issue is addressed with c4f9aee |
With loggingEnabled turned off, there is no limit to the size of log files in the LogFiles directory, unless a new iisnode instance is spun up
The text was updated successfully, but these errors were encountered: