Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form array is no longer working #79

Closed
silentworks opened this issue Jan 12, 2021 · 4 comments
Closed

Form array is no longer working #79

silentworks opened this issue Jan 12, 2021 · 4 comments

Comments

@silentworks
Copy link

silentworks commented Jan 12, 2021

Describe the bug

Whenever you try to create a form array the error nodes aren't being created. I suspect this commit 704f461 caused this issue to happen. When I roll back to version 1.2.2 of the library it is all working as expected.

To Reproduce
Steps to reproduce the behavior:

You can see the errors here
https://codesandbox.io/s/recursing-mccarthy-wne6b?file=/App.svelte

Expected behavior

This should not error and the $errors store should have some default array values but instead, it has an empty string as its value.

@silentworks silentworks changed the title I suspect this commit broke Form array is no longer working Jan 12, 2021
larrybotha added a commit that referenced this issue Jan 12, 2021
larrybotha added a commit that referenced this issue Jan 12, 2021
@larrybotha
Copy link
Collaborator

@silentworks thanks for reporting! Awaiting approval of a PR over at #80 to address this.

@larrybotha
Copy link
Collaborator

@silentworks this should be fixed as per #80. You can pull 1.3.1 for the updates.

@silentworks
Copy link
Author

@larrybotha thanks for this, it works like a charm.

@leocaseiro
Copy link

mm, seems that this PR introduce an error for primitive arrays: #185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants