Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better send logic #21

Closed
tkowalcz opened this issue Jan 22, 2021 · 0 comments · Fixed by #24
Closed

Better send logic #21

tkowalcz opened this issue Jan 22, 2021 · 0 comments · Fixed by #24
Labels
core Relates to Core component

Comments

@tkowalcz
Copy link
Owner

Tjahzi does too much http calls to Loki - whenever there is any message present and it check this typically with 1ms interval. We need to throttle that.

Introduce logic similar to promtail that will send logs when they reach some critical size or timeout is reached.
@tkowalcz tkowalcz added the core Relates to Core component label Jan 22, 2021
tkowalcz added a commit that referenced this issue Jan 23, 2021
@tkowalcz
Re #21: Added more elaborate logic to decide when we should send data…
81ebb09 
… to Loki. Using terminology from promtail introduced 'batchSize' and 'batchWait' parameters. Fixed ByteBuf and HttpMessage leak due to missing release.
tkowalcz added a commit that referenced this issue Jan 24, 2021
@tkowalcz
Merge pull request #24 from tkowalcz/21-send-logic
8a02d34 
Re #21: Added more elaborate logic to decide when we should send data…
@tkowalcz tkowalcz linked a pull request Jan 24, 2021 that will close this issue
Re #21: Added more elaborate logic to decide when we should send data… #24
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Relates to Core component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re #21: Added more elaborate logic to decide when we should send data… tkowalcz/tjahzi
1 participant
@tkowalcz