python3.10: numpy update and explicit int() #207
Conversation
imyxh
changed the title
| @@ -53,14 +53,14 @@ def include_dirs(self, dirs): | |||
| "sounddevice==0.4.2", | |||
| "rtmixer==0.1.3", | |||
| "docutils==0.17.1", | |||
| "numpy==1.21.1", | |||
| "numpy>=1.21.1", | |||
There was a problem hiding this comment.
Could we pin to the precise version that's needed ?
I guess that 1.21.5 or 1.22.1 ?
In the future I might move to a different build tool that supports locking the whole dependency tree, but in the meantime I prefer to have pinned versions to avoid unexpected build failures when a package gets silently upgraded to a newer version.
| "PyQt5==5.15.4", | ||
| "appdirs==1.4.4", | ||
| "pyrr==0.10.3", | ||
| ] | ||
|
|
||
| # Cython and numpy are needed when running setup.py, to build extensions | ||
| setup_requires=["numpy==1.21.1", "Cython==0.29.24"] | ||
| setup_requires=["numpy>=1.21.1", "Cython==0.29.24"] |
There was a problem hiding this comment.
Same comment as above, thanks !
|
|
||
| @pyqtSlot(float, result=float) | ||
| @pyqtSlot(int, result=float) |
There was a problem hiding this comment.
hmm, I think this one is not correct. The coordinates on the plot area are usually floats, they do not round nicely to integers.
| @@ -58,25 +58,31 @@ def setBorders(self, start, end): | |||
| def setScale(self, scale): | |||
| self.scale = scale | |||
|
|
|||
| @pyqtSlot(float, result=float) | |||
| @pyqtSlot(float, result=int) | |||
There was a problem hiding this comment.
if it's possible, I think this method should keep returning floats. It might sound strange that screen coordinates would not be integers, but with display scaling this might not be that unusual
|
Okay, sounds good! I just pushed a new commit to my fork but for some reason it hasn't shown up here.... If it takes much longer I can just make a new PR. |
|
Uhhhh okay I'm closing this one and submitting a new PR, someone else had the same issue and filed a bug here: community/community#10767 |
python3.10: numpy update and explicit int() #207
numpy>=1.21.1.Fixes #204.
Fixes #206.