Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.10: numpy update and explicit int() #207 #208

Merged
merged 2 commits into from
Feb 13, 2022

Conversation

imyxh
Copy link
Contributor

@imyxh imyxh commented Jan 30, 2022

Continuation of pull request #207, which failed to update on my new commit for some reason??

  • In Python 3.10, the Numpy C extensions refuse to build; this is fixed by setting the dependency to numpy>=1.21.
  • Implicit conversions to int are deprecated and enforced, as of Python 2.10. I think I have removed all implicit conversions from float to int, but I might've missed some, or done something in the wrong way. Review would be appreciated.

Fixes #204.
Fixes #206.

@tlecomte
Copy link
Owner

Thank you very much @imyxh !! Sorry for the delay before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.10 support (building) Python 3.10 support (automatic float truncation)
2 participants