Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement protocol 3.17.0 #10

Open
grouville opened this issue May 12, 2022 · 6 comments
Open

Implement protocol 3.17.0 #10

grouville opened this issue May 12, 2022 · 6 comments
Assignees

Comments

@grouville
Copy link
Contributor

grouville commented May 12, 2022

Hello,
First of all, thanks for the library.

It is very good, and I'm currently experimenting the creation of a language server based on it (and your puccini-language-server as a reference) 🙏

The spec just got upgraded a few days ago to 3.17.0 (05/10/2022), we should upgrade the protocol accordingly (if it's not too much effort).

I'm ready to help, still working around your code atm, but totally available 😇

@grouville
Copy link
Contributor Author

grouville commented May 12, 2022

Ok, I checked the changes, I think I can fire a PR by the end of week (if you don't see any complication I might have missed). Could you please assign it to me ?

@tliron
Copy link
Owner

tliron commented May 12, 2022

You are an angel, thank you! Will happily assign to you.

@grouville
Copy link
Contributor Author

I didn't forget you @tliron, still implementing the language server first before upgrading the protocol (if that's ok with you)

@semanticart
Copy link

👋 Hi, folks. Is there anything I can do to help move this forward? I'm a new user to this library and would love to use 3.17-specific types. Thanks!

@tliron
Copy link
Owner

tliron commented Feb 29, 2024

@semanticart Thank you for volunteering to submit a PR for 3.17 support. :)

@redexp
Copy link

redexp commented Oct 1, 2024

Good day everyone

I'm looking on code of protocol_3_17 and as for me you are going hard way. As for me it will be easier to create separated repo with just protocol_3_16 and to fork it as protocol_3_17 (so any bug fixes from 3.16 can be merged to 3.17) and so on protocol_3_18... so any fixes to previous versions could be merged to last one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants