feat: Add support for highlighting CVEs refercned in changelog entries #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philroche
changed the title
philroche
force-pushed
the
feature/highlight-cves
branch
7 times, most recently
from
a3ec468 to
1025d3f
Compare
Some changelog entries can be very long and hard to manually parse, especially when looking for references to CVEs in kernel changelogs. This commits adds three new arguments. All three are flags. `--highlight-cves`: Highlight the CVEs referenced in each individual changelog entry `--highlight-cves-only`: Highlight the CVEs referenced in each individual changelog entry but do NOT show the rest of the content of the changelog entry `--highlight-cves-show-cve-description`: When highlighting CVEs, show the CVE description `--highlight-cves` or `--highlight-cve-only` must also be used for this to take affect. Examples added to Readme too.
philroche
force-pushed
the
feature/highlight-cves
branch
from
1025d3f to
9735c28
Compare
toabctl
reviewed
Nov 14, 2022
|
|
||
| # this is the first line of a changelog entry. Find the version and reset lists for | ||
| # changelog entry lines and changelog entry cves | ||
| if source_package_name in line and line.startswith(source_package_name) and ' (' in line and ')' in line: |
There was a problem hiding this comment.
can we use the python-debian module to do that? then we would get a list of changes from that module. eg:
c = debian.changelog.Changelog(open('/home/tom/tmp/changelog'))
I also wonder if we should add a method to that module to get a list of CVEs (similar to the method which provides a list of closed LP bugs:
>>> c[0].lp_bugs_closed
[1989194, 1993204]
…o highlight If not, state that there are no CVEs addressed/mitigated for this version.
philroche
force-pushed
the
feature/highlight-cves
branch
from
4d84c71 to
8dd48c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changelog entries can be very long and hard to manually parse, especially when looking for references to CVEs in kernel changelogs.
This commits adds three new arguments. All three are flags.
--highlight-cves:Highlight the CVEs referenced in each individual changelog entry
--highlight-cves-only:Highlight the CVEs referenced in each individual changelog entry
but do NOT show the rest of the content of the changelog entry
--highlight-cves-show-cve-description:When highlighting CVEs, show the CVE description
--highlight-cvesor--highlight-cve-onlymust also be used for this to take affect.Examples added to Readme too.