Skip to content
This repository has been archived by the owner on Jul 19, 2018. It is now read-only.

Latest commit

 

History

History
26 lines (18 loc) · 1.23 KB

CONTRIBUTING.md

File metadata and controls

26 lines (18 loc) · 1.23 KB

ua-parser has moved

This project has moved to a new project space ua-parser, separating the regexes from the parsers for the different languages into their own repos.

Please contribute to the respective repositories there! Thanks.


Contributing Changes to regexes.yaml

Contributing to the project, especially regexes.yaml, is both welcomed and encouraged. To do so just do the following:

  1. Fork the project
  2. Create a branch for your changes
  3. Modify regexes.yaml as appropriate
  4. Add tests to the following files and follow their format:
    • test_resources/test_device.yaml
    • test_resources/test_user_agent_parser.yaml
    • test_resources/test_user_agent_parser_os.yaml
  5. Push your branch to GitHub and submit a pull request
  6. Monitor the pull request to make sure the Travis build succeeds. If it fails simply make the necessary changes to your branch and push it. Travis will re-test the changes.

That's it. If you don't feel comfortable forking the project or modifying the YAML you can also submit an issue that includes the appropriate user agent string and the expected results of parsing.

Thanks!