Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview link broken on files uploaded with Dreamform (getkirby/kirby#6786) #98

Open
samlinck opened this issue Nov 7, 2024 · 7 comments
Labels
needs: information ❓ Further information is requested

Comments

@samlinck
Copy link

samlinck commented Nov 7, 2024

When clicking on the preview button nothing happens. The preview button of other files does work as expected.
When manually copying the file url the file can be accessed.

image

Also in the default mail message, nothing is said about a file being uploaded. Could be an enhancement to provide a link to the uploaded file?
image

@tobimori
Copy link
Owner

tobimori commented Nov 7, 2024

In DreamForm 1.5.0 you can choose to add the files as attachment to the email. It's not possible to add the links to the email since the file is uploaded/created in Kirby after the email is send. See more here.

@tobimori
Copy link
Owner

tobimori commented Nov 7, 2024

Honestly, I'm a bit confused about this report, it works fine on my environments - both with images and other file types.

@samlinck
Copy link
Author

samlinck commented Nov 8, 2024

Okay very nice that it will be available in 1.5.0!
It's indeed a strange bug, maybe some other plugin or setting is conflicting with it. I will let you know if I know some more.

@samlinck
Copy link
Author

samlinck commented Nov 8, 2024

So the weird thing is, that the preview button isn't a link for me.
image

@tobimori
Copy link
Owner

tobimori commented Nov 8, 2024

I just found the same issue with some video files that were normally uploaded via the panel - unrelated to DreamForm. Seems like a Core bug?

@samlinck
Copy link
Author

I opened a new issue: getkirby/kirby#6786

@dominiklaube
Copy link

I had this issue in other contexts with Kirby one day ago. If you upload a file to a page with a blueprint, where the blueprint permisson for preview is set to false, then this happens.

Also the fiel preview urls follow some more conditions - see here https://github.com/getkirby/kirby/blob/eb47158e91e74184ab291ede020664f1d2829f74/src/Cms/File.php#L652

@tobimori tobimori changed the title Preview link broken on files uploaded with Dreamform Preview link broken on files uploaded with Dreamform (getkirby/kirby#6786) Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: information ❓ Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants