Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LR1110 library for WM1110 LoRa radio #490

Merged
merged 10 commits into from
Feb 24, 2025
Merged

Add LR1110 library for WM1110 LoRa radio #490

merged 10 commits into from
Feb 24, 2025

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Jan 29, 2025

This is a followup to #458 with the commits cleaned up.

We've verified that with tock/tock#4320 this is working and we can join TTN with the board and send sensor readings.

We have three patches to core files in the library that we found we needed when trying to get this working. We don't have the bandwidth to investigate those further right now, and while there has been some activity to the upstream repo, there haven't been any source changes in two years.

This isn't a perfect port, but it is self contained and we want to build on this.

@brghena brghena added the WG-Network In the purview of the Network working group. label Feb 10, 2025
brghena
brghena previously approved these changes Feb 10, 2025
Copy link
Contributor

@brghena brghena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Lots of high-quality, self-contained stuff

@brghena
Copy link
Contributor

brghena commented Feb 10, 2025

Can you clarify the relationship between this and #458? Does this PR replace that PR? (It looks to me like it does)

@bradjc
Copy link
Contributor Author

bradjc commented Feb 14, 2025

Can you clarify the relationship between this and #458? Does this PR replace that PR? (It looks to me like it does)

Yes this replaces it with a cleaned up commit history.

@bradjc
Copy link
Contributor Author

bradjc commented Feb 14, 2025

Ok the CI passes!

@brghena brghena added this pull request to the merge queue Feb 24, 2025
Merged via the queue into master with commit 8212d86 Feb 24, 2025
4 checks passed
@brghena brghena deleted the lr1110-library branch February 24, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
last-call WG-Network In the purview of the Network working group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants