Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix new clippy lint #2994

Merged
merged 1 commit into from
Oct 17, 2024
Merged

chore: fix new clippy lint #2994

merged 1 commit into from
Oct 17, 2024

Conversation

mladedav
Copy link
Collaborator

Motivation

beta has a new lint about eliding lifetimes in impls.

Solution

Elided the lifetimes as suggested by clippy.

I've also checked that nightly doesn't trigger any new lints so we should be ok for 3 months again.

@mladedav mladedav requested a review from jplatte October 16, 2024 21:02
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mladedav
Copy link
Collaborator Author

There are still some issues with linking an aws sys library in rustls examples. I'm not sure what's the issue, I'll see if I can make it work tomorrow.

@mladedav
Copy link
Collaborator Author

What I think has happened is our cache does not take into account the runner and in the last month GitHub switched the ubuntu-latest runner from 22.04 to 24.04. Our cache looks at the hash of our dependencies and the compiler so it reused older cache which was originally used for the beta toolchain since it's the same compiler as the current stable toolchain. But the -sys library used older libc in the 22.04 image for compilation and some functions then weren't available for linking in the 24.04.

Anyway, that's just my theory. I've deleted the one cache entry and it runs now, so hopefully it's going to be fine going forward.

@mladedav mladedav merged commit 65ad603 into tokio-rs:main Oct 17, 2024
34 of 36 checks passed
@jplatte
Copy link
Member

jplatte commented Oct 17, 2024

That makes sense, I heard that they updated -latest to 24.04 but rolled it back because it broke so many things. Want to open up a follow-up PR to go to -24.04 explicitly? Probably not a great idea to use the unversioned one anywhere.

jplatte pushed a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants