Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webpki #82

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Remove webpki #82

merged 1 commit into from
Mar 30, 2023

Conversation

paolobarbolini
Copy link
Contributor

Removes webpki from the public API, matching the rustls 0.20 move to also remove it from its public API rustls/rustls#736.
Unfortunately this PR is a breaking change as webpki was being re-exported by tokio-rustls.

@quininer
Copy link
Member

Good catch. but this is a breaking change, so it should be left to next version.

djc
djc previously approved these changes Oct 25, 2021
@djc djc dismissed their stale review October 25, 2021 12:57

Hasty

@djc
Copy link
Contributor

djc commented Oct 25, 2021

Clearly this is not ready yet, but it would be good to have. Probably can wait until rustls/rustls#839 is fixed, though.

@quininer
Copy link
Member

We will release 0.24 soon, would you like to rework it?

@paolobarbolini
Copy link
Contributor Author

Done

Copy link
Member

@quininer quininer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants