Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong log level in tracing macro warn #1929

Closed
nicolaasg opened this issue Feb 16, 2022 · 1 comment · Fixed by #1930
Closed

Wrong log level in tracing macro warn #1929

nicolaasg opened this issue Feb 16, 2022 · 1 comment · Fixed by #1930
Labels
crate/tracing Related to the `tracing` crate kind/bug Something isn't working

Comments

@nicolaasg
Copy link
Contributor

tracing/tracing/src/macros.rs

Line 1698 in 4e65750

$crate::Level::TRACE,

I was scrolling through the code in tracing/src/macros.rs and noticed a possibly wrong log level in the warn macro.
@hawkw
Copy link
Member

hawkw commented Feb 16, 2022

Whoops, that definitely looks wrong! Would you be interested in opening a pull request to fix that?

@hawkw hawkw added crate/tracing Related to the `tracing` crate kind/bug Something isn't working labels Feb 16, 2022
nicolaasg pushed a commit to nicolaasg/tracing that referenced this issue Feb 16, 2022
tracing: Fix wrong log level in warn macro
96066cd 
Fixes: tokio-rs#1929
@nicolaasg nicolaasg mentioned this issue Feb 16, 2022
Merged
hawkw pushed a commit that referenced this issue Feb 16, 2022
@nicolaasg
tracing: fix wrong log level in warn! macro (#1930)
55e6c98 
## Motivation

I was scrolling through the code in `tracing/src/macros.rs` and noticed
a possibly wrong log level in the `warn!` macro:

https://github.com/tokio-rs/tracing/blob/4e65750b13721fee7a7ac05b053e1b9c3d21244f/tracing/src/macros.rs#L1698

## Solution

This branch changes the level to `Level::WARN` in the incorrect macro
 arm.

Fixes: #1929

Co-authored-by: Nicolaas Geldenhuys <nicolaas.geldenhuys@cartrack.com>
hawkw pushed a commit that referenced this issue Feb 17, 2022
@nicolaasg @hawkw
tracing: fix wrong log level in warn! macro (#1930)
e6ddd21 
## Motivation

I was scrolling through the code in `tracing/src/macros.rs` and noticed
a possibly wrong log level in the `warn!` macro:

https://github.com/tokio-rs/tracing/blob/4e65750b13721fee7a7ac05b053e1b9c3d21244f/tracing/src/macros.rs#L1698

## Solution

This branch changes the level to `Level::WARN` in the incorrect macro
 arm.

Fixes: #1929

Co-authored-by: Nicolaas Geldenhuys <nicolaas.geldenhuys@cartrack.com>
hawkw pushed a commit that referenced this issue Feb 17, 2022
@nicolaasg @hawkw
tracing: fix wrong log level in warn! macro (#1930)
b37d8af 
## Motivation

I was scrolling through the code in `tracing/src/macros.rs` and noticed
a possibly wrong log level in the `warn!` macro:

https://github.com/tokio-rs/tracing/blob/4e65750b13721fee7a7ac05b053e1b9c3d21244f/tracing/src/macros.rs#L1698

## Solution

This branch changes the level to `Level::WARN` in the incorrect macro
 arm.

Fixes: #1929

Co-authored-by: Nicolaas Geldenhuys <nicolaas.geldenhuys@cartrack.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crate/tracing Related to the `tracing` crate kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tracing: Fix wrong log level in warn macro #1929 nicolaasg/tracing
2 participants
@hawkw @nicolaasg