-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare to release tracing-core 0.1.16 #968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can publish a new tracing
until #954 is resolved. 0.1.20 had to be yanked due to inadvertently breaking existing code. I'm happy to merge this with a tracing
version bump as well, but I won't publish a new tracing
release until we figure out that issue.
I think that if we go ahead and ship a new core
, most users should still be able to pick up the fix. We might want to publish a new tracing-subscriber
, with an updated tracing-core
dep, as well, since it was a tracing-subscriber
API that broke as a result of the LevelFilter
change?
0fb744c
to
3c8a9e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we ought to do a tracing-subscriber
release as well, but we can do that in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of changelog nits
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Preparing a release containing changes #966.